Skip to content

test/experiment_options_test.dart relies on "bogus" features defined by analyzer package #2156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
stereotype441 opened this issue Mar 3, 2020 · 1 comment
Closed

test/experiment_options_test.dart relies on "bogus" features defined by analyzer package #2156

stereotype441 opened this issue Mar 3, 2020 · 1 comment
Assignees
@scheglov
Labels
P2 A bug or feature request we're likely to work on

Comments

@stereotype441
Copy link
Member

The test experiment_options_test.dart relies on the presence of two "bogus" entries in the analyzer's ExperimentStatus.knownFeatures map. These entries were not intended to be kept around in the long term; they were created solely to illustrate the file format while it was being developed. We should change the dartdoc test so that it doesn't require them. This could be accomplished, for example, by making use of the analyzer's overrideKnownFeatures method.

Making this change would allow us to address analyzer technical debt issue dart-lang/sdk#40860.
@stereotype441 stereotype441 mentioned this issue Mar 3, 2020
Closed
@jcollins-g jcollins-g added the P2 A bug or feature request we're likely to work on label Mar 3, 2020
dart-bot pushed a commit to dart-lang/sdk that referenced this issue Jul 7, 2020
@scheglov
Update dartdoc to 0.32.2.
7255b99 
So, that we unblock #40860

Bug: dart-lang/dartdoc#2156
Change-Id: I0e4df8527b2868863de42d631c0833bd38fb448c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/153420
Reviewed-by: Brian Wilkerson <[email protected]>
Reviewed-by: Devon Carew <[email protected]>
Commit-Queue: Konstantin Shcheglov <[email protected]>
@scheglov scheglov self-assigned this Jul 9, 2020
@scheglov
Copy link
Contributor

scheglov commented Jul 9, 2020

This was fixed.

@scheglov scheglov closed this as completed Jul 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@scheglov scheglov

Labels
P2 A bug or feature request we're likely to work on
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@stereotype441 @scheglov @jcollins-g