Skip to content

fix an issue where we created a temporary directory when performing a dry run #3334

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 13, 2023
Merged

fix an issue where we created a temporary directory when performing a dry run #3334

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,12 @@
## 6.2.0-dev

* Stop generating a null-safety badge for elements
in a null-safe library. (#3295)
* Stop generating a null-safety badge for elements in a null-safe library.
(#3295)
* Use a sun icon for switching to the light theme. (#3309)
* Standardize the search icon style to a new SVG. (#3302)
* Remove CSS classes no longer used in dartdoc generated content. (#3302)
* Fix an issue where we created a temporary directory when performing a dry run.
(#3333)

## 6.1.5

Expand Down
1 change: 1 addition & 0 deletions lib/options.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,7 @@ class DartdocProgramOptionContext extends DartdocGeneratorOptionContext
super.optionSet, super.resourceProvider)
: super.fromDefaultContextLocation();

/// Whether to generate docs or perform a dry run.
bool get generateDocs => optionSet['generateDocs'].valueAt(context);
bool get help => optionSet['help'].valueAt(context);
bool get version => optionSet['version'].valueAt(context);
Expand Down
3 changes: 0 additions & 3 deletions lib/src/dartdoc.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -204,9 +204,6 @@ class Dartdoc {
var libs = packageGraph.libraryCount;
logInfo("Initialized dartdoc with $libs librar${libs == 1 ? 'y' : 'ies'}");

// Create the out directory.
if (!_outputDir.exists) _outputDir.create();
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is created later on when actually generating docs (or at least, not creating it doesn't seem to prevent doc generation).


runtimeStats.startPerfTask('generator.generate');
await generator.generate(packageGraph);
runtimeStats.endPerfTask();
Expand Down