Skip to content

Change mixin implements and remove unused Extendable. #3709

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 8, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/src/model/documentation_comment.dart
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ final _htmlInjectRegExp = RegExp(r'<dartdoc-html>([a-f0-9]+)</dartdoc-html>');
/// [_processCommentWithoutTools] and [processComment] are the primary
/// entrypoints.
mixin DocumentationComment
on Canonicalization, Documentable, Warnable, Locatable, SourceCode {
implements Canonicalization, Documentable, Warnable, Locatable, SourceCode {
@override
Element get element;

Expand Down
17 changes: 0 additions & 17 deletions lib/src/model/extendable.dart

This file was deleted.

2 changes: 1 addition & 1 deletion lib/src/model/has_no_page.dart
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
import 'package:dartdoc/src/model/model.dart';

/// An element which has no page documenting itself.
mixin HasNoPage on ModelElement {
mixin HasNoPage implements ModelElement {
@override
String get filePath =>
throw UnimplementedError('This element has no generated page');
Expand Down
2 changes: 1 addition & 1 deletion lib/src/model/inheriting_container.dart
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ import 'package:meta/meta.dart';
///
/// Note that [Constructor]s are not considered to be modifiers so a
/// [hasModifiers] override is not necessary for this mixin.
mixin Constructable on InheritingContainer {
mixin Constructable implements InheritingContainer {
late final List<Constructor> constructors = element.constructors
.map((e) => getModelFor(e, library) as Constructor)
.toList(growable: false);
Expand Down
1 change: 0 additions & 1 deletion lib/src/model/model.dart
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@ export 'documentation_comment.dart';
export 'dynamic.dart';
export 'enclosed_element.dart';
export 'enum.dart';
export 'extendable.dart';
export 'extension.dart';
export 'extension_type.dart';
export 'field.dart';
Expand Down