Use 'named' extension in tests #3790
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CC @dart-lang/analyzer-team |
scheglov
approved these changes
Jun 17, 2024
copybara-service bot
pushed a commit
to dart-lang/sdk
that referenced
this pull request
Jun 18, 2024
Revisions updated by `dart tools/rev_sdk_deps.dart`. async (https://github.com/dart-lang/async/compare/a004370..d7c0cd5): d7c0cd5 2024-06-17 Kevin Moore Drop use of pkg:collection whereNotNull() (dart-archive/async#278) dartdoc (https://github.com/dart-lang/dartdoc/compare/14d33d3..818d1f5): 818d1f52 2024-06-17 Sam Rawlins Minor improvement to the 'documentedWhere' comment (dart-lang/dartdoc#3789) 39591df5 2024-06-17 Sam Rawlins Pipe the '--stats' flag through for the 'doc sdk' task (dart-lang/dartdoc#3791) 6b2ee570 2024-06-17 Sam Rawlins Use 'named' extension in tests (dart-lang/dartdoc#3790) fabc394b 2024-06-17 Sam Rawlins Add more information to various asserts. (dart-lang/dartdoc#3787) 64982f89 2024-06-17 Parker Lougheed Update to package:lints v4 (dart-lang/dartdoc#3785) http_parser (https://github.com/dart-lang/http_parser/compare/71b4c2c..9bf7bd9): 9bf7bd9 2024-06-17 Kevin Moore Prepare release v4.1.0 (dart-archive/http_parser#100) shelf (https://github.com/dart-lang/shelf/compare/4c54af6..2536c15): 2536c15 2024-06-17 Graciliano Monteiro Passos `Headers.fromEntries`: using `CaseInsensitiveMap.fromEntries` (dart-lang/shelf#437) Change-Id: Iff49c7356534f950147b2c0c087e59414a6fc393 Tested: pkg/vm changes are updating test expectations Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/372101 Commit-Queue: Devon Carew <[email protected]> Reviewed-by: Konstantin Shcheglov <[email protected]> Auto-Submit: Devon Carew <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'd added this
namedextension a while ago for new tests, but didn't realize how much it could be used in the existing e2e tests.Contribution guidelines:
dart format.Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.