MultipartRequest of the Http package percent-encodes form field names

[DartBot]

Originally opened as dart-lang/sdk#17899

This issue was originally filed by [email protected]

---

What steps will reproduce the problem?

1. Create an instance of MultipartRequest as your HTTP request.
2. Add a form field to your request object created in step 1 with a name that contains non-alphanumeric (but still ASCII contained) characters, such as the string: "login[username]".
3. POST the form, for example with this code: new http.Client().send(yourRequestObject);

What is the expected output? What do you see instead?
The form field's name should stay untouched, but the braces get percent encoded and the request gets rejected by the server (tested with PHP/5.4.4-14+deb7u8 plus nginx/1.2.1)

What version of the product are you using? On what operating system?
OS X 10.9.2
Dart SDK 1.2.0

Please provide any additional information below.

The source of the problem is this code snippet from packages/http/src/multipart_request.dart
var header = 'content-disposition: form-data; name="${Uri.encodeFull(name)}"';

The previous snippet's comment (pasted below) states that this is intended and the goal was to reproduce the behaviour of browsers.
Still, posting a form with the mentioned field name included, both Chrome and Firefox will leave it as is, and the POST will be accepted by the same back-end mentioned above.

// http://tools.ietf.org/html/rfc2388 mandates some complex encodings for
// field names and file names, but in practice user agents seem to just
// URL-encode them so we do the same.

I understand that implementing the 'complex encodings' can be kind of a grunt work, without too much leverage. But even simply leaving out the encoding would be better for my use-case.

I also wonder if there is already a well written utility class exactly for the mentioned 'complex encoding' somewhere in the chromium source. If yes, that probably could help a lot, simplifying the task to a C => Dart translation, just guessing here.

Anyways, from my side the only goal would be to make the same forms work that are working well on the major browsers already, maybe those aren't even RFC compliant either.

Peter

[DartBot]

<img src="https://avatars.githubusercontent.com/u/8631949?v=3" align="left" width="48" height="48"hspace="10"> Comment by floitschG

---

Added Area-IO, Triaged labels.

[DartBot]

<img src="https://avatars.githubusercontent.com/u/1343914?v=3" align="left" width="48" height="48"hspace="10"> Comment by sgjesse

---

Removed Area-IO label.
Added Pkg-Http label.

[DartBot]

<img src="https://avatars.githubusercontent.com/u/188?v=3" align="left" width="48" height="48"hspace="10"> Comment by nex3

---

Set owner to @nex3.
Added Started label.

[DartBot]

<img src="https://avatars.githubusercontent.com/u/188?v=3" align="left" width="48" height="48"hspace="10"> Comment by nex3

---

Fixed by dart-lang/sdk@a750dea.

---

Added Fixed label.