Skip to content

Correct the pubspec.yaml, we require 1.23.0 #58

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 6, 2017
Merged

Correct the pubspec.yaml, we require 1.23.0 #58

merged 1 commit into from
Mar 6, 2017

Conversation

matanlurey
Copy link
Contributor

... for importing dart:io into Dartium, specifically it looks like.

Closes #57.

@dustyholmes-wf
Copy link

It seems that this solution will leave people on 1.22.0 pulling version 0.11.3+10 incorrectly. Should there be a version in between this fix and the current that corrects the library for the stable release of dart?

@matanlurey
Copy link
Contributor Author

I think we're going to try and pull the previous version... @kevmoo any update?

@nex3
Copy link
Member

nex3 commented Feb 17, 2017

Can you add a CHANGELOG entry for this?

@matanlurey
Copy link
Contributor Author

I don't want to merge this until we figure out how to fix the previous release (i.e. either roll it back first or publish a new 1.22.0 release with the last commit reverted). @kevmoo WDUT?

@kevmoo
Copy link
Member

kevmoo commented Feb 17, 2017 via email

@dustyholmes-wf
Copy link

I no longer see 0.11.3+10 on pub. Looks like it has been rolled back.

@nex3
Copy link
Member

nex3 commented Feb 17, 2017

Yep, I yanked 0.11.3+10. Given that, I think it might make sense to wait on landing/releasing 0.11.3+11 until 1.23 is stable. @kevmoo, how urgent is it that we have a mirrorless version of this released?

@kevmoo
Copy link
Member

kevmoo commented Feb 17, 2017 via email

@kevmoo
Copy link
Member

kevmoo commented Feb 23, 2017

@nex3 Let's get this out w/ the -dev constraint. It'll let our flutter folks roll forward.

@tvolkert
Copy link
Contributor

tvolkert commented Mar 1, 2017

Even once SDK 1.23 is stable, some users won't have it, so do we need to release a 0.11.3+11 version cut off a branch that doesn't import dart:io anyway?

@nex3
Copy link
Member

nex3 commented Mar 6, 2017

@tvolkert No, we yanked the version with the invalid SDK constraint.

@nex3 nex3 merged commit 2d2738d into master Mar 6, 2017
@nex3 nex3 deleted the pubspec-fix branch March 6, 2017 20:36
nex3 pushed a commit that referenced this pull request Mar 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants