-
Notifications
You must be signed in to change notification settings - Fork 380
Correct the pubspec.yaml, we require 1.23.0 #58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
It seems that this solution will leave people on 1.22.0 pulling version 0.11.3+10 incorrectly. Should there be a version in between this fix and the current that corrects the library for the stable release of dart? |
I think we're going to try and pull the previous version... @kevmoo any update? |
Can you add a CHANGELOG entry for this? |
I don't want to merge this until we figure out how to fix the previous release (i.e. either roll it back first or publish a new 1.22.0 release with the last commit reverted). @kevmoo WDUT? |
I vote for rollback. My understanding is that natalie is running w/ that -
as of an hour ago...
…On Fri, Feb 17, 2017 at 2:43 PM, Matan Lurey ***@***.***> wrote:
I don't want to merge this until we figure out how to fix the previous
release (i.e. either roll it back first or publish a new 1.22.0 release
with the last commit reverted). @kevmoo <https://github.com/kevmoo> WDUT?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#58 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AABCijZuQEafXEkt1oIPM4HyFSqIHr_Wks5rdiKggaJpZM4MEhly>
.
|
I no longer see 0.11.3+10 on pub. Looks like it has been rolled back. |
Yep, I yanked 0.11.3+10. Given that, I think it might make sense to wait on landing/releasing 0.11.3+11 until 1.23 is stable. @kevmoo, how urgent is it that we have a mirrorless version of this released? |
Natalie: will follow-up w/ you offline.
…On Fri, Feb 17, 2017 at 3:05 PM, Natalie Weizenbaum < ***@***.***> wrote:
Yep, I yanked 0.11.3+10. Given that, I think it might make sense to wait
on landing/releasing 0.11.3+11 until 1.23 is stable. @kevmoo
<https://github.com/kevmoo>, how urgent is it that we have a mirrorless
version of this released?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#58 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AABCirhYvUHm6oxpgp_MeOwvdhe0RegFks5rdifTgaJpZM4MEhly>
.
|
@nex3 Let's get this out w/ the |
Even once SDK 1.23 is stable, some users won't have it, so do we need to release a |
@tvolkert No, we yanked the version with the invalid SDK constraint. |
... for importing
dart:io
into Dartium, specifically it looks like.Closes #57.