Don't quote the multipart boundary header. #63
Conversation
This is be more broadly compatible than the quoted version, although the quoted version is what's described by the spec. curl and browsers send unquoted boundaries, so we can safely assume that any server will support them. Closes #61
| @@ -83,7 +83,7 @@ class MultipartRequest extends BaseRequest { | |||
| ByteStream finalize() { | |||
| // TODO(nweiz): freeze fields and files | |||
| var boundary = _boundaryString(); | |||
| headers['content-type'] = 'multipart/form-data; boundary="$boundary"'; | |||
| headers['content-type'] = 'multipart/form-data; boundary=$boundary'; | |||
There was a problem hiding this comment.
I think we'll have to remove 39 (') and 61 (=) in _BOUNDARY_CHARACTERS for this to really work. I'd actually leave just alpha-numerics, 95 (underscore) and 45 (hyphen). I think all others play some special role in URL encoding, so I'd leave them out just in case.
There was a problem hiding this comment.
Here are the suspicious ones:
39: '
40: (
41: )
43: +
44: ,
46: .
47: /
58: :
61: =
63: ?
There was a problem hiding this comment.
I don't want to go alphanumeric-only unless we absolutely have to, but I've removed all the characters that aren't valid in MIME tokens.
|
FYI, this change causes the following tests to fail: https://github.com/dart-lang/http/blob/0.11.3%2B12/test/multipart_test.dart FYI, I've disabled the tests internally when bumping the version of |
|
@yjbanov any chance you could look at the failing tests? |
|
I'll take a look. |
This is be more broadly compatible than the quoted version, although the quoted version is what's described by the spec. curl and browsers send unquoted boundaries, so we can safely assume that any server will support them. Closes dart-lang#61
This is be more broadly compatible than the quoted version, although the quoted version is what's described by the spec. curl and browsers send unquoted boundaries, so we can safely assume that any server will support them. Closes dart-lang#61
This is be more broadly compatible than the quoted version, although the
quoted version is what's described by the spec. curl and browsers send
unquoted boundaries, so we can safely assume that any server will
support them.
Closes #61