-
Notifications
You must be signed in to change notification settings - Fork 5
[io_file] Add the ability to get file metadata on Windows. #202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
brianquinlan
wants to merge
53
commits into
dart-lang:main
Choose a base branch
from
brianquinlan:metadata
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
53 commits
Select commit
Hold shift + click to select a range
5db08c8
Add `rename` support for Windows
brianquinlan a6f5c1c
Update rename_test.dart
brianquinlan f89d063
Some fixes
brianquinlan 0f81c95
Update vm_windows_file_system.dart
brianquinlan ed98ec4
Update vm_windows_file_system.dart
brianquinlan 2dfc83b
Test utils
brianquinlan 8bf09fb
Metadata
brianquinlan 1dcd074
Set metadata
brianquinlan 2877b5e
Update vm_windows_file_system.dart
brianquinlan 7e4717d
Tests
brianquinlan 278de74
Merge branch 'main' into metadata
brianquinlan 69490d5
Fixes
brianquinlan 9704766
Windows metadata tests
brianquinlan 36647c2
More windows properties
brianquinlan a363b49
Update vm_windows_file_system.dart
brianquinlan 305655c
Test fixes
brianquinlan 88dc69e
Update metadata_windows_test.dart
brianquinlan 647a6a5
size
brianquinlan f7c6d76
creation time
brianquinlan dd67782
not such path
brianquinlan 9185690
GetLastError
brianquinlan a687b84
Update metadata_test.dart
brianquinlan e3fc41a
Times
brianquinlan 309c186
More fixes
brianquinlan 2c51b7d
More tests
brianquinlan fa3e0a2
Update metadata_windows_test.dart
brianquinlan b287897
Docs
brianquinlan b88bfca
Update vm_windows_file_system.dart
brianquinlan d14f1a9
Update vm_windows_file_system.dart
brianquinlan 4d8ccfd
Code review updates
brianquinlan 1aeb152
Review feedback.
brianquinlan 4fd4da1
Merge branch 'main' into metadata
brianquinlan b6ffeff
Add library
brianquinlan 8c95248
Update file_system.dart
brianquinlan 18e6f8b
Review comments
brianquinlan 186c228
Update file_system.dart
brianquinlan 7d11d36
Update file_system_test.dart
brianquinlan 90d4070
Update vm_windows_file_system.dart
brianquinlan c878448
Merge remote-tracking branch 'upstream/main' into pr/brianquinlan/202
brianquinlan 0188da6
Allow if original metadata
brianquinlan ea0946f
Update vm_windows_file_system.dart
brianquinlan e28568d
Fixes
brianquinlan 49cbe04
Merge remote-tracking branch 'upstream/main' into metadata
brianquinlan d614fad
Update vm_posix_file_system.dart
brianquinlan a2cef78
Maybe this works?
brianquinlan 3ecea3f
Update pubspec.yaml
brianquinlan 5ff9dea
Update vm_windows_file_system.dart
brianquinlan 8f85c57
Fix
brianquinlan 86e013c
Harmonize
brianquinlan b3cea51
Update vm_windows_file_system.dart
brianquinlan e59c2de
Merge remote-tracking branch 'upstream/main' into metadata
brianquinlan 99cd5af
Update pubspec.yaml
brianquinlan f5bbc52
Update vm_posix_file_system.dart
brianquinlan File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(For future extension: The OSX file system has a hidden flag too, you can set it with
chflags hidden /path/to/folder/
. Not all tools recognize it - Finder does,ls
doesn't. It's from BSD, so other Unixes might have it too. We should probably support it if possible/reasonable.)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, linux has a hidden flag too - it's just not used in many file systems. I plan on moving some of these attributes around when I do the POSIX stat implementation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Given that the semantics probably are quite different it makes a lot of sense to not share the hidden flag between platforms though they are named the same...