Skip to content

add a script to regenerate the gRPC library; commit generated gRPC libraries #237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

devoncarew
Copy link
Member

  • add a script to regenerate the gRPC library
  • commit generated gRPC libraries

Done as two commits for easier review (the 2nd commit will be large).


  • I’ve reviewed the contributor guide and applied the relevant portions to this PR.
Contribution guidelines:

Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.

@github-actions github-actions bot added the type-infra A repository infrastructure change or enhancement label May 22, 2025
@devoncarew devoncarew requested a review from natebosch May 22, 2025 14:31
@devoncarew
Copy link
Member Author

@craiglabenz, if you want to review, that would be helpful. The 2nd commit is very large but all machine generated; the bulk of the hand-written code is in the first commit.

The goal here is to generate an initial version of a gRPC Firestore client, and then fix up the generator (package:protoc_plugin) enough so that the client is functional, esp. wrt the Firestore.listen.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package:googleapis_firestore_v1 type-infra A repository infrastructure change or enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant