Skip to content

Added null-shorting rule to treat selector ! like other selectors #1162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 14, 2020

Conversation

eernstg
Copy link
Member

@eernstg eernstg commented Aug 19, 2020

Cf. dart-lang/sdk#43093.

Update: That issue is now closed, and more recent discussions can be found in #1163.

@eernstg
Copy link
Member Author

eernstg commented Oct 9, 2020

@lrhn, didn't we conclude that ! participates in null-shorting, both when it occurs in a chain of selectors and when it occurs at the end (the language team meeting minutes are somewhat ambiguous)?

@leafpetersen, do you agree that this behavior can be specified as proposed in this PR?

Copy link
Member

@leafpetersen leafpetersen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

@eernstg eernstg merged commit 997d7b6 into master Oct 14, 2020
@eernstg eernstg deleted the spec_bang_nullshorting_aug20 branch October 14, 2020 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants