[extension types] Specify promotion of representation variables #3411
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lrhn
reviewed
Oct 18, 2023
lrhn
approved these changes
Oct 18, 2023
copybara-service bot
pushed a commit
to dart-lang/sdk
that referenced
this pull request
Oct 27, 2023
…able. Update the type inference algorithm so that `FlowAnalysis.propertyGet` is appropriately called when analyzing code that refers to the representation variable of an extension type. Flow analysis requires an arbitrary `Object` to represent the property in question; this is later passed to `OperationsCfe.isPropertyPromotable`. We use the synthetic "representation field" (which is actually a `Procedure`) for this purpose (`ExtensionTypeRepresentationAccessTarget.representationField`). Representation variables are considered promotable if they are public (see dart-lang/language#3411). `OperationsCfe.isPropertyPromotable` can tell if the representation variable is public by checking the name of the synthetic representation field. Fixes #53439. Bug: #53439 Change-Id: I8f7ff8fcd8e5a43de419b8441951b52a555fda1a Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/332480 Commit-Queue: Paul Berry <[email protected]> Reviewed-by: Chloe Stefantsova <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR specifies how promotion of the representation variable of an extension type proceeds: It is applicable to any representation variable whose name is private, and it does not interfere with promotion of private class instance variables, or vice versa.
See this comment.