-
Notifications
You must be signed in to change notification settings - Fork 68
[native_assets_cli] Refactor API #11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hey @mkustermann, I've addressed some of your comments in this PR. PTAL, as well as to the open questions in the PR description. |
final String name; | ||
final String description; | ||
final List<Packaging> preferredPackaging; | ||
final List<Packaging> potentialPackaging; | ||
final List<LinkMode> preferredLinkMode; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this a List? As we can have only 2 entries and only one of them could be our preferred way.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't touch this yet because of :
LinkingPreference { static, dynamic, any } means we cannot eagerly fail on the build in the package itself returning an error and non-0 exit code. Maybe that's okay, but it would lead to some wasted work if it's a longer build.
Let's solve that question first, then I clean this up.
We don't support building both anymore.
Some of the refactorings need some more discussion, I've opened issues to track these: Merging this with the first batch of refactorings. |
Some open questions:
Linking
andLinkingPreference
instead ofLinkMode
andLinkModePreference
?LinkingPreference { static, dynamic, any }
means we cannot eagerly fail on the build in the package itself returning an error and non-0 exit code. Maybe that's okay, but it would lead to some wasted work if it's a longer build.BuildConfig
BuildOutput
hierarchy #12BuildOutput
Initial version #3 (comment)