Skip to content

Reenable example on CI + roll dep #122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 6, 2023
Merged

Reenable example on CI + roll dep #122

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e49b277
Reenable example on CI + roll dep
dcharkes Sep 6, 2023
32c5998
Rev the right dependency
dcharkes Sep 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions .github/workflows/dart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,8 +23,7 @@ jobs:
sdk: [stable, dev]
package: [native_assets_builder, native_assets_cli, native_toolchain_c]
# Breaking changes temporarily break the example run on the Dart SDK until native_assets_builder is rolled into the Dart SDK dev build.
# TODO(https://github.com/dart-lang/native/issues/116): Set to false.
breaking-change: [true]
breaking-change: [false]
exclude:
# Only run analyze against dev on one host.
- os: macos
Expand Down
2 changes: 1 addition & 1 deletion pkgs/native_assets_builder/test/data/native_add/pubspec.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ dependencies:
cli_config: ^0.1.1
logging: ^1.1.1
native_assets_cli: ^0.2.0
native_toolchain_c: ^0.2.0
native_toolchain_c: ^0.2.2

dev_dependencies:
ffigen: ^8.0.2
Expand Down
2 changes: 1 addition & 1 deletion pkgs/native_assets_builder/test/data/native_add_add_source/pubspec.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ dependencies:
cli_config: ^0.1.1
logging: ^1.1.1
native_assets_cli: ^0.2.0
native_toolchain_c: ^0.2.0
native_toolchain_c: ^0.2.2

dev_dependencies:
ffigen: ^8.0.2
Expand Down
2 changes: 1 addition & 1 deletion pkgs/native_assets_builder/test/data/native_subtract/pubspec.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ dependencies:
cli_config: ^0.1.1
logging: ^1.1.1
native_assets_cli: ^0.2.0
native_toolchain_c: ^0.2.0
native_toolchain_c: ^0.2.2

dev_dependencies:
ffigen: ^8.0.2
Expand Down
2 changes: 1 addition & 1 deletion pkgs/native_assets_cli/example/native_add_library/pubspec.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ dependencies:
cli_config: ^0.1.1
logging: ^1.1.1
native_assets_cli: ^0.2.0
native_toolchain_c: ^0.2.0
native_toolchain_c: ^0.2.2

dev_dependencies:
ffigen: ^8.0.2
Expand Down