Skip to content

[native_assets_cli] Cleanup JSON: old code config #2221

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 22, 2025
Merged

Conversation

dcharkes
Copy link
Collaborator

@dcharkes dcharkes commented Apr 22, 2025

@dcharkes dcharkes force-pushed the json-cleanup-config branch from d122f72 to 8479bb4 Compare April 22, 2025 15:47
Copy link

github-actions bot commented Apr 22, 2025

PR Health

Breaking changes ✔️
Package Change Current Version New Version Needed Version Looking good?
native_assets_cli Breaking 0.16.0 0.17.0-wip 0.17.0 ✔️
API leaks ✔️

The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.

Package Leaked API symbols
License Headers ✔️
// Copyright (c) 2025, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
Files
no missing headers

All source files should start with a license header.

Unrelated files missing license headers
Files
pkgs/jni/lib/src/third_party/generated_bindings.dart
pkgs/objective_c/lib/src/ns_input_stream.dart

Copy link

auto-submit bot commented Apr 22, 2025

autosubmit label was removed for dart-lang/native/2221, because - The status or check suite health / changelog / run changelog health check has failed. Please fix the issues identified (or deflake) before re-applying this label.

Copy link

auto-submit bot commented Apr 22, 2025

autosubmit label was removed for dart-lang/native/2221, because - The status or check suite health / changelog / run changelog health check has failed. Please fix the issues identified (or deflake) before re-applying this label.

@dcharkes dcharkes merged commit 75d4813 into main Apr 22, 2025
85 of 89 checks passed
@dcharkes dcharkes deleted the json-cleanup-config branch April 22, 2025 16:06
@coveralls
Copy link

Coverage Status

coverage: 77.625%. first build
when pulling 8479bb4 on json-cleanup-config
into fdd7672 on main.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants