Skip to content

[native_assets_cli] Cleanup JSON: version, out_dir, and out_file #2222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 23, 2025

Conversation

dcharkes
Copy link
Collaborator

@dcharkes dcharkes commented Apr 22, 2025

Copy link

github-actions bot commented Apr 22, 2025

PR Health

Breaking changes ✔️
Package Change Current Version New Version Needed Version Looking good?
native_assets_builder Breaking 0.16.0 0.17.0-wip 0.17.0 ✔️
native_assets_cli Breaking 0.16.0 0.17.0-wip 0.17.0 ✔️
native_toolchain_c Non-Breaking 0.13.0 0.14.0-wip 0.13.1 ✔️
API leaks ✔️

The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.

Package Leaked API symbols
License Headers ✔️
// Copyright (c) 2025, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
Files
no missing headers

All source files should start with a license header.

Unrelated files missing license headers
Files
pkgs/jni/lib/src/third_party/generated_bindings.dart
pkgs/objective_c/lib/src/ns_input_stream.dart

@dcharkes dcharkes requested review from goderbauer and mosuem April 22, 2025 16:14
@coveralls
Copy link

Coverage Status

coverage: 77.554%. first build
when pulling d73bc76 on json-cleanup-outdir
into 75d4813 on main.

Copy link

@goderbauer goderbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dcharkes dcharkes merged commit 24f71bf into main Apr 23, 2025
48 of 50 checks passed
@dcharkes dcharkes deleted the json-cleanup-outdir branch April 23, 2025 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants