-
Notifications
You must be signed in to change notification settings - Fork 68
[native_assets_cli] Simplify library structure #2244
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
PR HealthBreaking changes ✔️
API leaks ✔️The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.
License Headers ✔️
All source files should start with a license header. Unrelated files missing license headers
|
1 similar comment
PR HealthBreaking changes ✔️
API leaks ✔️The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.
License Headers ✔️
All source files should start with a license header. Unrelated files missing license headers
|
ffe609b
to
4bceaaf
Compare
f70376f
to
3abc1ea
Compare
3abc1ea
to
397768c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Closes: #1805
This PR merges the
_testing
and_builder
libraries into the "hook" libraries.This leads to one library per package once we split it up in
package:hooks
,package:data_assets
, andpackage:code_assets
(#999).Upside:
Input
s and readingOutput
s)Input
s and readingOutput
s in its tests)Input
s, and writingOutput
s)