Skip to content

[native_assets_cli] Simplify library structure #2244

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 28, 2025
Merged

Conversation

dcharkes
Copy link
Collaborator

Closes: #1805

This PR merges the _testing and _builder libraries into the "hook" libraries.

This leads to one library per package once we split it up in package:hooks, package:data_assets, and package:code_assets (#999).

Upside:

  • Only one import instead of two for the following use cases:
    • tests testing hooks (constructing Inputs and reading Outputs)
    • hook helper packages (constructing Inputs and reading Outputs in its tests)
  • This leads to more classes available in scope than needed in the following use case:
    • hooks (only reading Inputs, and writing Outputs)

Copy link

PR Health

Breaking changes ✔️
Package Change Current Version New Version Needed Version Looking good?
native_assets_builder Non-Breaking 0.17.0 0.18.0-wip 0.17.1 ✔️
native_assets_cli Breaking 0.17.0 0.18.0-wip 0.18.0 ✔️
native_toolchain_c Non-Breaking 0.14.0 0.15.0-wip 0.14.1 ✔️
API leaks ✔️

The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.

Package Leaked API symbols
License Headers ✔️
// Copyright (c) 2025, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
Files
no missing headers

All source files should start with a license header.

Unrelated files missing license headers
Files
pkgs/jni/lib/src/third_party/generated_bindings.dart
pkgs/objective_c/lib/src/ns_input_stream.dart

1 similar comment
Copy link

PR Health

Breaking changes ✔️
Package Change Current Version New Version Needed Version Looking good?
native_assets_builder Non-Breaking 0.17.0 0.18.0-wip 0.17.1 ✔️
native_assets_cli Breaking 0.17.0 0.18.0-wip 0.18.0 ✔️
native_toolchain_c Non-Breaking 0.14.0 0.15.0-wip 0.14.1 ✔️
API leaks ✔️

The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.

Package Leaked API symbols
License Headers ✔️
// Copyright (c) 2025, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
Files
no missing headers

All source files should start with a license header.

Unrelated files missing license headers
Files
pkgs/jni/lib/src/third_party/generated_bindings.dart
pkgs/objective_c/lib/src/ns_input_stream.dart

@dcharkes dcharkes force-pushed the cleanup-old-resource-identifiers branch from ffe609b to 4bceaaf Compare April 25, 2025 16:29
@dcharkes dcharkes force-pushed the cleanup-imports-5 branch from f70376f to 3abc1ea Compare April 25, 2025 16:29
Base automatically changed from cleanup-old-resource-identifiers to main April 25, 2025 16:39
@dcharkes dcharkes force-pushed the cleanup-imports-5 branch from 3abc1ea to 397768c Compare April 25, 2025 16:40
@coveralls
Copy link

Coverage Status

coverage: 77.937% (-0.5%) from 78.419%
when pulling 397768c on cleanup-imports-5
into deda4d1 on main.

Copy link

@goderbauer goderbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dcharkes dcharkes merged commit cb27933 into main Apr 28, 2025
24 checks passed
@dcharkes dcharkes deleted the cleanup-imports-5 branch April 28, 2025 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[native_assets_cli] Reduce number of visible libraries in package
3 participants