Move package:native_assets_builder
#69
Conversation
github-actions
bot
added
the
type-infra
|
@devoncarew Because this package is the shared implementation between dartdev and flutter_tools, and should not be used by users, we could consider hiding it in the main README.md table. What do you think? Should it be in there or not? Edit: the test mono repo lists all packages, but provides no description for the internal/private ones: https://github.com/dart-lang/test/tree/master |
I guess I have mixed feelings. I'd normally say to list everything (for completeness, and to help users understand the repo contents). You'd then use the description column and or the published/version column to help indicate which packages were more user facing and which more impl. details. There might be some types of packages that I would strip out I suppose - like test support / fixture packages. |
The Dart SDK CL for dart-lang/native#69. Bug: dart-lang/native#67 Change-Id: I45d7ac691a6aaa41bce5be0e36403021a948bb4f Cq-Include-Trybots: luci.dart.try:pkg-linux-debug-try,pkg-linux-release-try,pkg-mac-release-arm64-try,pkg-mac-release-try,pkg-win-release-try Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/311740 Reviewed-by: William Hesse <[email protected]> Commit-Queue: Daco Harkes <[email protected]> Reviewed-by: Devon Carew <[email protected]>
Added support for Java arrays. Closed #69. * `jni`: Added `JniArray<T>` and `JniType<T>` that includes signature information about Java types. * `jnigen` generates an extension for `JniArray<GeneratedClass>` so we can use `operator []` and `operator []=` on all arrays. `jni` types also have this extension. * Arrays also have a `setRange` method similar to `List`s. * `jnigen` generates a private type class that extends `JniType<GeneratedClass>` accessible through `.type` static getter. This is useful for creating arrays since they require a type parameter like `JniArray(JniString.type, 5)` which creates an array of `JniString` with a length of 5.
Added support for Java arrays. Closed #69. * `jni`: Added `JniArray<T>` and `JniType<T>` that includes signature information about Java types. * `jnigen` generates an extension for `JniArray<GeneratedClass>` so we can use `operator []` and `operator []=` on all arrays. `jni` types also have this extension. * Arrays also have a `setRange` method similar to `List`s. * `jnigen` generates a private type class that extends `JniType<GeneratedClass>` accessible through `.type` static getter. This is useful for creating arrays since they require a type parameter like `JniArray(JniString.type, 5)` which creates an array of `JniString` with a length of 5.
Closes:
And has a ton of small fixes due to the extra checks on the CI here: