[c_compiler] Rename package to native_toolchain_c
#87
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
type-infra
Package publishing
Documentation at https://github.com/dart-lang/ecosystem/wiki/Publishing-automation. |
HosseinYousefi
approved these changes
Jul 11, 2023
copybara-service bot
pushed a commit
to dart-lang/sdk
that referenced
this pull request
Jul 11, 2023
Rolling dart-lang/native#87 manually because of the c_compiler -> native_toolchain_c rename. Change-Id: I2592882a7137a40703f96a487a66d31eac7c990d Cq-Include-Trybots: luci.dart.try:pkg-linux-debug-try,pkg-linux-release-try,pkg-mac-release-arm64-try,pkg-mac-release-try,pkg-win-release-try Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/313200 Commit-Queue: Daco Harkes <[email protected]> Reviewed-by: Devon Carew <[email protected]>
HosseinYousefi
pushed a commit
that referenced
this pull request
Nov 16, 2023
…port. (#87) * C bindings no longer use fully qualified names. Instead, it uses number-renamed simple names. The classes are sorted in the summarizer to ensure the order is deterministic. This enables shorter symbol names and less verbose bindings. * C bindings are formatted using same style as Dart SDK, using clang-format. If clang-format is not available, jnigen will issue a warning. Closes: #84 * C bindings return `JniResult`. The older `Jni.checkException` stopgap is removed. It reduces one line per function binding in dart. Lastly exceptions will work properly on android Closes: #56
HosseinYousefi
pushed a commit
that referenced
this pull request
Nov 16, 2023
…port. (#87) * C bindings no longer use fully qualified names. Instead, it uses number-renamed simple names. The classes are sorted in the summarizer to ensure the order is deterministic. This enables shorter symbol names and less verbose bindings. * C bindings are formatted using same style as Dart SDK, using clang-format. If clang-format is not available, jnigen will issue a warning. Closes: #84 * C bindings return `JniResult`. The older `Jni.checkException` stopgap is removed. It reduces one line per function binding in dart. Lastly exceptions will work properly on android Closes: #56
HosseinYousefi
pushed a commit
that referenced
this pull request
Nov 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #85
This will need a manual roll into the Dart SDK to update the package name: