quick fixes for EXTENSION_{TYPE_}DECLARES_MEMBER_OF_OBJECT

Quick fixes for:

* `EXTENSION_DECLARES_MEMBER_OF_OBJECT`
* `EXTENSION_TYPE_DECLARES_MEMBER_OF_OBJECT

See: #55917


Change-Id: I4a3576f7e78c58a4cf7dd6d659b576f2c7f11279
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/371686
Reviewed-by: Brian Wilkerson <[email protected]>
Commit-Queue: Phil Quitslund <[email protected]>

Author: pq

pkg/analysis_server/lib/src/services/correction/error_fix_status.yaml

@@ -45,8 +45,8 @@
 #
 # Stats:
 # -  42 "needsEvaluation"
-# - 318 "needsFix"
-# - 429 "hasFix"
+# - 316 "needsFix"
+# - 431 "hasFix"
 # - 517 "noFix"
 
 AnalysisOptionsErrorCode.INCLUDED_FILE_PARSE_ERROR:
@@ -645,9 +645,7 @@ CompileTimeErrorCode.EXTENSION_AS_EXPRESSION:
 CompileTimeErrorCode.EXTENSION_CONFLICTING_STATIC_AND_INSTANCE:
   status: noFix
 CompileTimeErrorCode.EXTENSION_DECLARES_MEMBER_OF_OBJECT:
-  status: needsFix
-  notes: |-
-    Offer to delete the invalid member.
+  status: hasFix
 CompileTimeErrorCode.EXTENSION_OVERRIDE_ACCESS_TO_STATIC_MEMBER:
   status: hasFix
 CompileTimeErrorCode.EXTENSION_OVERRIDE_ARGUMENT_NOT_ASSIGNABLE:
@@ -667,9 +665,7 @@ CompileTimeErrorCode.EXTENSION_TYPE_CONSTRUCTOR_WITH_SUPER_INVOCATION:
 CompileTimeErrorCode.EXTENSION_TYPE_DECLARES_INSTANCE_FIELD:
   status: noFix
 CompileTimeErrorCode.EXTENSION_TYPE_DECLARES_MEMBER_OF_OBJECT:
-  status: needsFix
-  notes: |-
-    Offer to delete the invalid member.
+  status: hasFix
 CompileTimeErrorCode.EXTENSION_TYPE_IMPLEMENTS_DISALLOWED_TYPE:
   status: noFix
 CompileTimeErrorCode.EXTENSION_TYPE_IMPLEMENTS_ITSELF:

pkg/analysis_server/lib/src/services/correction/fix_internal.dart

@@ -944,6 +944,12 @@ final _builtInNonLintProducers = <ErrorCode, List<ProducerGenerator>>{
   CompileTimeErrorCode.EXTENDS_TYPE_ALIAS_EXPANDS_TO_TYPE_PARAMETER: [
     RemoveNameFromDeclarationClause.new,
   ],
+  CompileTimeErrorCode.EXTENSION_DECLARES_MEMBER_OF_OBJECT: [
+    RemoveMethodDeclaration.new,
+  ],
+  CompileTimeErrorCode.EXTENSION_TYPE_DECLARES_MEMBER_OF_OBJECT: [
+    RemoveMethodDeclaration.new,
+  ],
   CompileTimeErrorCode.EXTENSION_OVERRIDE_ACCESS_TO_STATIC_MEMBER: [
     ReplaceWithExtensionName.new,
   ],

pkg/analysis_server/test/src/services/correction/fix/remove_method_declaration_test.dart

@@ -13,6 +13,7 @@ void main() {
   defineReflectiveSuite(() {
     defineReflectiveTests(RemoveMethodDeclarationBulkTest);
     defineReflectiveTests(RemoveMethodDeclarationTest);
+    defineReflectiveTests(UnnecessaryOverridesTest);
   });
 }
 
@@ -48,7 +49,37 @@ class B extends A {
 }
 
 @reflectiveTest
-class RemoveMethodDeclarationTest extends FixProcessorLintTest {
+class RemoveMethodDeclarationTest extends FixProcessorTest {
+  @override
+  FixKind get kind => DartFixKind.REMOVE_METHOD_DECLARATION;
+
+  Future<void> test_extensionDeclaresMemberOfObject() async {
+    await resolveTestCode('''
+extension E on String {
+  bool operator==(Object _) => false;
+}
+''');
+    await assertHasFix('''
+extension E on String {
+}
+''');
+  }
+
+  Future<void> test_extensionTypeDeclaresMemberOfObject() async {
+    await resolveTestCode('''
+extension type E(int i) {
+  int get hashCode => 0;
+}
+''');
+    await assertHasFix('''
+extension type E(int i) {
+}
+''');
+  }
+}
+
+@reflectiveTest
+class UnnecessaryOverridesTest extends FixProcessorLintTest {
   @override
   FixKind get kind => DartFixKind.REMOVE_METHOD_DECLARATION;