Skip to content

☂️ Add Missing Quick-Fixes #55917

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
70 tasks done
pq opened this issue Jun 3, 2024 · 3 comments
Closed
70 tasks done

☂️ Add Missing Quick-Fixes #55917

pq opened this issue Jun 3, 2024 · 3 comments
Assignees
Labels
devexp-quick-fix Issues with analysis server (quick) fixes legacy-area-analyzer Use area-devexp instead. P2 A bug or feature request we're likely to work on type-enhancement A request for a change that isn't a bug

Comments

@pq
Copy link
Member

pq commented Jun 3, 2024

Tracking issue for newly added quick fixes.

Diagnostics with newly added fixes

  • EXPECTED_CATCH_CLAUSE_BODY @pq
  • EXPECTED_CLASS_BODY @pq
  • EXPECTED_EXTENSION_BODY @pq
  • EXPECTED_EXTENSION_TYPE_BODY @pq
  • EXPECTED_FINALLY_CLAUSE_BODY @pq
  • EXPECTED_MIXIN_BODY @pq
  • EXPECTED_SWITCH_EXPRESSION_BODY @pq
  • EXPECTED_SWITCH_STATEMENT_BODY @pq
  • EXPECTED_TRY_STATEMENT_BODY @pq
  • MISSING_ENUM_BODY @pq
  • EXTENSION_TYPE_DECLARES_MEMBER_OF_OBJECT @pq
  • EXTENSION_DECLARES_MEMBER_OF_OBJECT @pq
  • WRONG_SEPARATOR_FOR_POSITIONAL_PARAMETER @pq
  • SUBTYPE_OF_BASE_IS_NOT_BASE_FINAL_OR_SEALED @pq
  • SUBTYPE_OF_FINAL_IS_NOT_BASE_FINAL_OR_SEALED @pq
  • REPRESENTATION_FIELD_TRAILING_COMMA @pq
  • EMPTY_RECORD_TYPE_WITH_COMMA @pq
  • EMPTY_RECORD_LITERAL_WITH_COMMA @pq
  • STATIC_SETTER_WITHOUT_BODY @pq
  • STATIC_GETTER_WITHOUT_BODY @pq
  • LITERAL_WITH_NEW @pq
  • COLON_IN_PLACE_OF_IN @pq
  • MISSING_TYPEDEF_PARAMETERS @pq
  • INVALID_MODIFIER_ON_SETTER @pq
  • NULL_CHECK_ALWAYS_FAILS @pq
  • INVALID_USE_OF_COVARIANT @pq
  • STATIC_OPERATOR @pq
  • STATIC_CONSTRUCTOR @pq
  • NON_CONST_CALL_TO_LITERAL_CONSTRUCTOR_USING_NEW @pq
  • SETTER_CONSTRUCTOR @pq
  • GETTER_CONSTRUCTOR @pq
  • INVALID_USE_OF_COVARIANT_IN_EXTENSION @pq
  • EXTERNAL_TYPEDEF @pq
  • EXTERNAL_ENUM @pq
  • EXTERNAL_CLASS @pq
  • COVARIANT_MEMBER @pq
  • FACTORY_TOP_LEVEL_DECLARATION @pq
  • CONST_METHOD @pq
  • INTERFACE_MIXIN_CLASS @pq
  • FINAL_MIXIN_CLASS @pq
  • INTERFACE_MIXIN @pq
  • FINAL_MIXIN @pq
  • FINAL_METHOD @pq
  • FINAL_ENUM @pq
  • SEALED_MIXIN @pq
  • SEALED_MIXIN_CLASS @pq
  • FINAL_CONSTRUCTOR @pq
  • CONST_FACTORY @pq
  • ABSTRACT_STATIC_METHOD @pq
  • ABSTRACT_STATIC_FIELD @pq
  • MIXIN_SUBTYPE_OF_FINAL_IS_NOT_BASE @pq
  • MIXIN_SUBTYPE_OF_BASE_IS_NOT_BASE @pq
  • EXTENSION_TYPE_WITH_ABSTRACT_MEMBER @pq
  • CLASS_INSTANTIATION_ACCESS_TO_STATIC_MEMBER @pq
  • UNDEFINED_LINT @pq
  • REMOVED_RULE @pq
  • DUPLICATE_RULE @pq
  • EXTRANEOUS_MODIFIER @pq
  • DUPLICATED_MODIFIER @pq
  • CONST_CLASS @pq
  • MIXIN_CLASS_DECLARATION_EXTENDS_NOT_OBJECT @pq
  • IMPORT_OF_NON_LIBRARY @pq
  • INVALID_MODIFIER_ON_CONSTRUCTOR @pq
  • IMPORT_INTERNAL_LIBRARY @pq
  • EXTENSION_OVERRIDE_WITH_CASCADE @pq
  • AWAIT_IN_LATE_LOCAL_VARIABLE_INITIALIZER @pq
  • LATE_FINAL_LOCAL_ALREADY_ASSIGNED @pq
  • NO_ANNOTATION_CONSTRUCTOR_ARGUMENTS @pq
  • INVALID_REOPEN_ANNOTATION @pq
  • unnecessary_await_in_return @pq
@pq pq added legacy-area-analyzer Use area-devexp instead. devexp-quick-fix Issues with analysis server (quick) fixes P2 A bug or feature request we're likely to work on labels Jun 3, 2024
@pq pq self-assigned this Jun 3, 2024
copybara-service bot pushed a commit that referenced this issue Jun 3, 2024
See: #55917

Change-Id: I536eb9bf75ad1c7df3e697c75874954f4a882905
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/369503
Commit-Queue: Phil Quitslund <[email protected]>
Auto-Submit: Phil Quitslund <[email protected]>
Reviewed-by: Brian Wilkerson <[email protected]>
@pq pq changed the title ☂️ Add Missing Quick-Fixes for Dart 3.5 ☂️ Add Missing Quick-Fixes Jun 3, 2024
copybara-service bot pushed a commit that referenced this issue Jun 4, 2024
See: #55917

Change-Id: I2eab04ad9d2947c387b382809808165e1501c7b3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/369741
Reviewed-by: Brian Wilkerson <[email protected]>
Auto-Submit: Phil Quitslund <[email protected]>
Commit-Queue: Brian Wilkerson <[email protected]>
Commit-Queue: Phil Quitslund <[email protected]>
copybara-service bot pushed a commit that referenced this issue Jun 5, 2024
See: #55917

Change-Id: Id6f749fe0f7cb51403b0952abb2e2ba8a24d3120
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/369767
Commit-Queue: Brian Wilkerson <[email protected]>
Reviewed-by: Brian Wilkerson <[email protected]>
Auto-Submit: Phil Quitslund <[email protected]>
copybara-service bot pushed a commit that referenced this issue Jun 5, 2024
See: #55917

Change-Id: I330f1c571de0ecc4b2cef390ee98dd008dec9afc
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/369785
Reviewed-by: Brian Wilkerson <[email protected]>
Commit-Queue: Brian Wilkerson <[email protected]>
Commit-Queue: Phil Quitslund <[email protected]>
Auto-Submit: Phil Quitslund <[email protected]>
copybara-service bot pushed a commit that referenced this issue Jun 6, 2024
See: #55917

Change-Id: I0f60078bfcb3ae5ab6d559a9e2314abe209726bf
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/369880
Reviewed-by: Brian Wilkerson <[email protected]>
Commit-Queue: Phil Quitslund <[email protected]>
Auto-Submit: Phil Quitslund <[email protected]>
copybara-service bot pushed a commit that referenced this issue Jun 6, 2024
See: #55917

Change-Id: I3826969b5f20b2140fb522ab1882e5f2330cab5e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/369881
Commit-Queue: Brian Wilkerson <[email protected]>
Reviewed-by: Brian Wilkerson <[email protected]>
Auto-Submit: Phil Quitslund <[email protected]>
copybara-service bot pushed a commit that referenced this issue Jun 6, 2024
See: #55917

Change-Id: I1fac6f8f1bcdb0e2ede3f7766c24ada1ee037f45
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/370060
Auto-Submit: Phil Quitslund <[email protected]>
Commit-Queue: Phil Quitslund <[email protected]>
Reviewed-by: Brian Wilkerson <[email protected]>
Commit-Queue: Brian Wilkerson <[email protected]>
copybara-service bot pushed a commit that referenced this issue Jun 6, 2024
* Generalizes `RemoveExtraModifier` to a new `RemoveLexeme` producer that works for keywords and modifiers.

* Adds a new (keyword) quick-fix for the `GETTER_CONSTRUCTOR`


See: #55917


Change-Id: I0e7fbc33aa970f0754c9533b3ecbd4e9dd9ddb30
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/370100
Auto-Submit: Phil Quitslund <[email protected]>
Reviewed-by: Brian Wilkerson <[email protected]>
Commit-Queue: Phil Quitslund <[email protected]>
copybara-service bot pushed a commit that referenced this issue Jun 6, 2024
See: #55917

Change-Id: I0984ef126107974a611c2582402e4498514377d2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/370061
Commit-Queue: Phil Quitslund <[email protected]>
Auto-Submit: Phil Quitslund <[email protected]>
Commit-Queue: Brian Wilkerson <[email protected]>
Reviewed-by: Brian Wilkerson <[email protected]>
copybara-service bot pushed a commit that referenced this issue Jun 6, 2024
See: #55917

Change-Id: I3bfea0a3a300a478c80d64b0813c8cb5e9024227
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/370141
Reviewed-by: Brian Wilkerson <[email protected]>
Commit-Queue: Brian Wilkerson <[email protected]>
Auto-Submit: Phil Quitslund <[email protected]>
Commit-Queue: Phil Quitslund <[email protected]>
copybara-service bot pushed a commit that referenced this issue Jun 7, 2024
See: #55917

Change-Id: I9576105618d0201b4fdc339361b6c164870267b9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/370140
Reviewed-by: Brian Wilkerson <[email protected]>
Commit-Queue: Phil Quitslund <[email protected]>
Auto-Submit: Phil Quitslund <[email protected]>
@srawlins srawlins added the type-enhancement A request for a change that isn't a bug label Jun 7, 2024
copybara-service bot pushed a commit that referenced this issue Jun 8, 2024
See: #55917

Change-Id: I41dd40a11e98340dc90f3673c8c6b37e3bf3d7f2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/370161
Commit-Queue: Phil Quitslund <[email protected]>
Auto-Submit: Phil Quitslund <[email protected]>
Reviewed-by: Brian Wilkerson <[email protected]>
copybara-service bot pushed a commit that referenced this issue Jun 10, 2024
See: #55917

Change-Id: Ic38b8a9e9717fc477394ea19bbb7173b2234d2f6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/370380
Reviewed-by: Brian Wilkerson <[email protected]>
Commit-Queue: Brian Wilkerson <[email protected]>
copybara-service bot pushed a commit that referenced this issue Jun 10, 2024
See: #55917

Change-Id: I9e7ad32fb3aaea28c31b6b29af4b2f1233cb9f78
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/370360
Reviewed-by: Brian Wilkerson <[email protected]>
Commit-Queue: Brian Wilkerson <[email protected]>
Auto-Submit: Phil Quitslund <[email protected]>
copybara-service bot pushed a commit that referenced this issue Jun 11, 2024
See: #55917

Change-Id: I9b81940c1c515bf923ceecb83d5aaad1d416dab1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/370482
Commit-Queue: Phil Quitslund <[email protected]>
Reviewed-by: Brian Wilkerson <[email protected]>
copybara-service bot pushed a commit that referenced this issue Jun 11, 2024
See: #55917

Change-Id: Ieabdb7b9d12ef409d99497a32b6701a89c936434
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/370481
Commit-Queue: Phil Quitslund <[email protected]>
Reviewed-by: Brian Wilkerson <[email protected]>
copybara-service bot pushed a commit that referenced this issue Jun 11, 2024
See: #55917


Change-Id: I2dbe760dd0d123fc4b1bf493c8f7699baaea376c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/370503
Reviewed-by: Brian Wilkerson <[email protected]>
Commit-Queue: Phil Quitslund <[email protected]>
copybara-service bot pushed a commit that referenced this issue Jun 12, 2024
See: #55917

Change-Id: I43629f21645ed330b6a4732ae7f3e9ea616b3a97
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/370840
Auto-Submit: Phil Quitslund <[email protected]>
Reviewed-by: Brian Wilkerson <[email protected]>
Commit-Queue: Phil Quitslund <[email protected]>
copybara-service bot pushed a commit that referenced this issue Jun 12, 2024
See: #55917

Change-Id: I4a212bc638cc2a36d805af9eedd319fd3dc9c00b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/370881
Reviewed-by: Brian Wilkerson <[email protected]>
Commit-Queue: Phil Quitslund <[email protected]>
copybara-service bot pushed a commit that referenced this issue Jun 13, 2024
See: #55917

Change-Id: Id3b704915c03b61d9ba778b96c6e6fc55e1ef3dc
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/371060
Reviewed-by: Brian Wilkerson <[email protected]>
Commit-Queue: Phil Quitslund <[email protected]>
copybara-service bot pushed a commit that referenced this issue Jun 13, 2024
See: #55917

Change-Id: Ifee29c7623f3322d4a35534e1c2a00d1cd6b0b03
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/371063
Reviewed-by: Brian Wilkerson <[email protected]>
Commit-Queue: Phil Quitslund <[email protected]>
copybara-service bot pushed a commit that referenced this issue Jun 13, 2024
(Also improves fix description for `EMPTY_RECORD_LITERAL_WITH_COMMA`.)

See: #55917

Change-Id: I742506d8c1a77b10f99861aa84947f8d348916df
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/371342
Reviewed-by: Brian Wilkerson <[email protected]>
Auto-Submit: Phil Quitslund <[email protected]>
Commit-Queue: Phil Quitslund <[email protected]>
copybara-service bot pushed a commit that referenced this issue Jun 13, 2024
See: #55917

Change-Id: Ib278e49749618325c8c5fcc7a5627840f87c4553
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/371401
Commit-Queue: Brian Wilkerson <[email protected]>
Reviewed-by: Brian Wilkerson <[email protected]>
Auto-Submit: Phil Quitslund <[email protected]>
copybara-service bot pushed a commit that referenced this issue Jun 14, 2024
(`error_fix_status.yaml` to be updated when pending quick fixes are landed.)

See: #55917

Change-Id: I042f6dc2171a37d008c6c2c4d1f843e0bcffc46c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/371662
Commit-Queue: Phil Quitslund <[email protected]>
Reviewed-by: Brian Wilkerson <[email protected]>
copybara-service bot pushed a commit that referenced this issue Jun 14, 2024
Quick fixes for:

* `SUBTYPE_OF_BASE_IS_NOT_BASE_FINAL_OR_SEALED`
* `SUBTYPE_OF_FINAL_IS_NOT_BASE_FINAL_OR_SEALED`

See: #55917

Change-Id: I1ee373fb030a1570f93e3a7bee694aa0ecc974f0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/371683
Reviewed-by: Brian Wilkerson <[email protected]>
Auto-Submit: Phil Quitslund <[email protected]>
Commit-Queue: Phil Quitslund <[email protected]>
copybara-service bot pushed a commit that referenced this issue Jun 14, 2024
Quick fixes for:

* `EXTENSION_DECLARES_MEMBER_OF_OBJECT`
* `EXTENSION_TYPE_DECLARES_MEMBER_OF_OBJECT

See: #55917


Change-Id: I4a3576f7e78c58a4cf7dd6d659b576f2c7f11279
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/371686
Reviewed-by: Brian Wilkerson <[email protected]>
Commit-Queue: Phil Quitslund <[email protected]>
copybara-service bot pushed a commit that referenced this issue Jun 26, 2024
* `EXPECTED_CATCH_CLAUSE_BODY`
* `EXPECTED_CLASS_BODY`
* `EXPECTED_EXTENSION_BODY`
* `EXPECTED_EXTENSION_TYPE_BODY`
* `EXPECTED_FINALLY_CLAUSE_BODY`
* `EXPECTED_MIXIN_BODY`
* `EXPECTED_SWITCH_EXPRESSION_BODY`
* `EXPECTED_SWITCH_STATEMENT_BODY`
* `EXPECTED_TRY_STATEMENT_BODY`
* `MISSING_ENUM_BODY`

See: #55917


Change-Id: If33df1e9b3e93c7aaff30565f6d61dc56c24e491
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/373400
Reviewed-by: Brian Wilkerson <[email protected]>
Commit-Queue: Phil Quitslund <[email protected]>
@FMorschel
Copy link
Contributor

@pq, is there anything else that this is tracking or can this be closed?

@pq
Copy link
Member Author

pq commented Nov 13, 2024

Ah, yeah, I see I never captured all the remaining missing ones. I guess I'd prefer to keep it open and fill those in so we can have a central place to track the ongoing work.

@bwilkerson
Copy link
Member

Friendly ping.

Not sure what the value of this issue is, but if we aren't going to keep it current I'd recommend closing it.

@pq pq closed this as completed Jan 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
devexp-quick-fix Issues with analysis server (quick) fixes legacy-area-analyzer Use area-devexp instead. P2 A bug or feature request we're likely to work on type-enhancement A request for a change that isn't a bug
Projects
None yet
Development

No branches or pull requests

4 participants