Fix bug introduced in refactoring.

A constant was renamed to conform to the style guide, and that made it
have the same name as a local variable, and it was shadowed inside that function.

Rename another constant while we're here.

Fixes #45432.

Bug: http://dartbug.com/45432
Change-Id: Ie7e83bb77fea25a93a006bde78431ec35007a82a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/192920
Reviewed-by: Erik Ernst <[email protected]>
Commit-Queue: Lasse R.H. Nielsen <[email protected]>

Author: lrhn

sdk/lib/_internal/vm/lib/convert_patch.dart

@@ -231,11 +231,10 @@ class _ReviverJsonListener extends _BuildJsonListener {
  * These are all ASCII, so an [Uint8List] is used as backing store.
  *
  * This buffer is used when a JSON number is split between separate chunks.
- *
  */
 class _NumberBuffer {
   static const int minCapacity = 16;
-  static const int kDefaultOverhead = 5;
+  static const int defaultOverhead = 5;
   Uint8List list;
   int length = 0;
   _NumberBuffer(int initialCapacity)
@@ -246,12 +245,14 @@ class _NumberBuffer {
   // Pick an initial capacity greater than the first part's size.
   // The typical use case has two parts, this is the attempt at
   // guessing the size of the second part without overdoing it.
-  // The default estimate of the second part is [kDefaultOverhead],
+  // The default estimate of the second part is [defaultOverhead],
   // then round to multiplum of four, and return the result,
   // or [minCapacity] if that is greater.
   static int _initialCapacity(int minCapacity) {
-    minCapacity += kDefaultOverhead;
-    if (minCapacity < minCapacity) return minCapacity;
+    minCapacity += defaultOverhead;
+    if (minCapacity < _NumberBuffer.minCapacity) {
+      return _NumberBuffer.minCapacity;
+    }
     minCapacity = (minCapacity + 3) & ~3; // Round to multiple of four.
     return minCapacity;
   }
@@ -1214,7 +1215,7 @@ abstract class _ChunkedJsonParser<T> {
   // Continues an already chunked number across an entire chunk.
   int continueChunkNumber(int state, int start, _NumberBuffer buffer) {
     int end = chunkEnd;
-    addNumberChunk(buffer, start, end, _NumberBuffer.kDefaultOverhead);
+    addNumberChunk(buffer, start, end, _NumberBuffer.defaultOverhead);
     this.buffer = buffer;
     this.partialState = PARTIAL_NUMERAL | state;
     return end;