Skip to content

[convert_patch.dart] minCapacity < minCapacity never evaluates to true. #45432

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
modulovalue opened this issue Mar 23, 2021 · 2 comments
Closed

[convert_patch.dart] minCapacity < minCapacity never evaluates to true. #45432

modulovalue opened this issue Mar 23, 2021 · 2 comments
Labels
area-core-library SDK core library issues (core, async, ...); use area-vm or area-web for platform specific libraries.

Comments

@modulovalue
Copy link
Contributor

Hello,

sdk/sdk/lib/_internal/vm/lib/convert_patch.dart

Line 254 in 9d1a307

if (minCapacity < minCapacity) return minCapacity;

I believe this will always evaluate to false.
@mraleph
Copy link
Member

mraleph commented Mar 23, 2021

Good catch. It got broken during code review, original code said if (minCapacity < kMinCapacity) return kMinCapacity; but then kMinCapacity was renamed to match the code style.

@mraleph mraleph added the area-core-library SDK core library issues (core, async, ...); use area-vm or area-web for platform specific libraries. label Mar 23, 2021
@mraleph
Copy link
Member

mraleph commented Mar 23, 2021

/cc @lrhn

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-core-library SDK core library issues (core, async, ...); use area-vm or area-web for platform specific libraries.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mraleph @modulovalue