quick fix for EXTERNAL_CLASS

See: #55917

Change-Id: I330f1c571de0ecc4b2cef390ee98dd008dec9afc
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/369785
Reviewed-by: Brian Wilkerson <[email protected]>
Commit-Queue: Brian Wilkerson <[email protected]>
Commit-Queue: Phil Quitslund <[email protected]>
Auto-Submit: Phil Quitslund <[email protected]>

Author: pq

pkg/analysis_server/lib/src/services/correction/error_fix_status.yaml

@@ -45,8 +45,8 @@
 #
 # Stats:
 # -  42 "needsEvaluation"
-# - 343 "needsFix"
-# - 408 "hasFix"
+# - 342 "needsFix"
+# - 409 "hasFix"
 # - 516 "noFix"
 
 AnalysisOptionsErrorCode.INCLUDED_FILE_PARSE_ERROR:
@@ -2767,9 +2767,7 @@ ParserErrorCode.EXTENSION_TYPE_EXTENDS:
 ParserErrorCode.EXTENSION_TYPE_WITH:
   status: needsEvaluation
 ParserErrorCode.EXTERNAL_CLASS:
-  status: needsFix
-  notes: |-
-    Remove the `external` keyword.
+  status: hasFix
 ParserErrorCode.EXTERNAL_CONSTRUCTOR_WITH_BODY:
   status: needsFix
   notes: |-

pkg/analysis_server/lib/src/services/correction/fix_internal.dart

@@ -1382,6 +1382,9 @@ final _builtInNonLintProducers = <ErrorCode, List<ProducerGenerator>>{
   ParserErrorCode.EXTENSION_DECLARES_CONSTRUCTOR: [
     RemoveConstructor.new,
   ],
+  ParserErrorCode.EXTERNAL_CLASS: [
+    RemoveExtraModifier.new,
+  ],
   ParserErrorCode.EXTRANEOUS_MODIFIER: [
     RemoveExtraModifier.new,
   ],

pkg/analysis_server/test/src/services/correction/fix/remove_extra_modifier_test.dart

@@ -195,6 +195,15 @@ f() {
 ''');
   }
 
+  Future<void> test_externalClass() async {
+    await resolveTestCode(r'''
+external class C {}
+''');
+    await assertHasFix('''
+class C {}
+''');
+  }
+
   Future<void> test_final_constructor() async {
     await resolveTestCode('''
 class C {