quick fix for NULL_CHECK_ALWAYS_FAILS

See: #55917

Change-Id: Ic38b8a9e9717fc477394ea19bbb7173b2234d2f6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/370380
Reviewed-by: Brian Wilkerson <[email protected]>
Commit-Queue: Brian Wilkerson <[email protected]>

Author: pq

pkg/analysis_server/lib/src/services/correction/error_fix_status.yaml

@@ -45,8 +45,8 @@
 #
 # Stats:
 # -  42 "needsEvaluation"
-# - 335 "needsFix"
-# - 416 "hasFix"
+# - 334 "needsFix"
+# - 417 "hasFix"
 # - 516 "noFix"
 
 AnalysisOptionsErrorCode.INCLUDED_FILE_PARSE_ERROR:
@@ -3654,9 +3654,7 @@ WarningCode.NULL_ARGUMENT_TO_NON_NULL_TYPE:
   status: noFix
   since: ~2.15
 WarningCode.NULL_CHECK_ALWAYS_FAILS:
-  status: needsFix
-  notes: |-
-    Remove the null check.
+  status: hasFix
 WarningCode.OVERRIDE_ON_NON_OVERRIDING_FIELD:
   status: hasFix
 WarningCode.OVERRIDE_ON_NON_OVERRIDING_GETTER:

pkg/analysis_server/lib/src/services/correction/fix_internal.dart

@@ -1588,6 +1588,9 @@ final _builtInNonLintProducers = <ErrorCode, List<ProducerGenerator>>{
   WarningCode.NON_CONST_CALL_TO_LITERAL_CONSTRUCTOR_USING_NEW: [
     ReplaceNewWithConst.new,
   ],
+  WarningCode.NULL_CHECK_ALWAYS_FAILS: [
+    RemoveNonNullAssertion.new,
+  ],
   WarningCode.NULLABLE_TYPE_IN_CATCH_CLAUSE: [
     RemoveQuestionMark.new,
   ],

pkg/analysis_server/test/src/services/correction/fix/remove_non_null_assertion_test.dart

@@ -88,6 +88,19 @@ void f() {
   print(x);
   print(y);
 }
+''');
+  }
+
+  Future<void> test_nullCheckAlwaysFails() async {
+    await resolveTestCode('''
+void f() {
+  null!;
+}
+''');
+    await assertHasFix('''
+void f() {
+  null;
+}
 ''');
   }
 }