Skip to content

Commit c816c1d

Browse files
rmacnak-googleCommit Queue
rmacnak-google
authored and
Commit Queue
committed
[test] Remove ARM64-specific status entries.
In particular, this un-skips the service tests. TEST=ci Bug: b/302156166 Bug: #26109 Bug: #27806 Bug: #33057 Bug: #52589 Change-Id: Ieddf50ac6c27d23c5efa26a7e5bf7f9044350a5e Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/328381 Reviewed-by: Jonas Termansen <[email protected]> Commit-Queue: Ryan Macnak <[email protected]>
1 parent 260b9b1 commit c816c1d

File tree

13 files changed

+0
-60
lines changed

13 files changed

+0
-60
lines changed

‎pkg/status_file/test/data/standalone_2_vm.status

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -5,11 +5,6 @@
55
[ $runtime == vm && !$checked ]
66
io/file_constructor_test: RuntimeError
77

8-
[ $runtime == vm && ($arch == arm || $arch == arm64) ]
9-
io/file_stream_test: Skip # Issue 26109
10-
io/file_typed_data_test: Skip # Issue 26109
11-
io/file_input_stream_test: Skip # Issue 26109
12-
138
[ $runtime == vm && $system == windows && $mode == release ]
149
io/http_server_close_response_after_error_test: Pass, Timeout # Issue 28370: timeout.
1510
io/regress_7191_test: Pass, Timeout # Issue 28374: timeout.

‎runtime/observatory/tests/service/service.status

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -38,9 +38,6 @@ dev_fs_http_put_weird_char_test: Skip # Windows disallows carriage returns in pa
3838
dev_fs_weird_char_test: Skip # Windows disallows question mark in paths
3939
uri_mappings_lookup_test: SkipByDesign # Relies on file paths in the SDK.
4040

41-
[ $arch == arm64 && $system == linux ]
42-
*: Skip # dartbug.com/52589 Builder timing out. Re-enable after we migrate from the Cavium to GCE.
43-
4441
[ $compiler == dartk && $runtime == vm && $system == fuchsia ]
4542
*: Skip # Not yet triaged.
4643

‎runtime/observatory/tests/service/service_kernel.status

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -190,12 +190,6 @@ vm_timeline_flags_test: SkipByDesign # Debugger is disabled in AOT mode.
190190
weak_properties_test: SkipByDesign # Uses 'dart:mirrors' library
191191
yield_positions_with_finally_test: SkipByDesign # Debugger is disabled in AOT mode.
192192

193-
[ $arch == arm64 && $compiler == dartk ]
194-
coverage_optimized_function_test: Pass, Slow
195-
196-
[ $arch == arm64 && $compiler == dartk && $mode == release ]
197-
get_object_rpc_test: Pass, RuntimeError # Please triage / issue #27806
198-
199193
[ $arch == ia32 && $builder_tag == optimization_counter_threshold ]
200194
eval_regression_flutter20255_test: SkipSlow # Timeout
201195
get_vm_timeline_rpc_test: Pass, Slow

‎runtime/observatory_2/tests/service_2/service_2_kernel.status

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -206,12 +206,6 @@ vm_timeline_flags_test: SkipByDesign # Debugger is disabled in AOT mode.
206206
weak_properties_test: SkipByDesign # Uses 'dart:mirrors'
207207
yield_positions_with_finally_test: SkipByDesign # Debugger is disabled in AOT mode.
208208

209-
[ $arch == arm64 && $compiler == dartk ]
210-
coverage_optimized_function_test: Pass, Slow
211-
212-
[ $arch == arm64 && $compiler == dartk && $mode == release ]
213-
get_object_rpc_test: Pass, RuntimeError # Please triage / issue #27806
214-
215209
[ $arch == ia32 && $builder_tag == optimization_counter_threshold ]
216210
eval_regression_flutter20255_test: SkipSlow # Timeout
217211
get_vm_timeline_rpc_test: Pass, Slow

‎runtime/tests/vm/vm.status

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -293,10 +293,6 @@ dart_2/unboxed_param_args_descriptor_test: SkipByDesign # https://dartbug.com/37
293293
dart_2/unboxed_param_tear_off_test: SkipByDesign # https://dartbug.com/37299 FFI helper not supported on simulator
294294
dart_2/unboxed_param_test: SkipByDesign # https://dartbug.com/37299 FFI helper not supported on simulator
295295

296-
[ $arch == arm64 && $system == linux ]
297-
dart/gc/fragmentation*: Skip # dartbug.com/52589 Uses a lot of memory. Re-enable after we migrate from the Cavium to GCE.
298-
dart/gc/out_of_memory*: Skip # dartbug.com/52589 Uses a lot of memory. Re-enable after we migrate from the Cavium to GCE.
299-
300296
[ $arch == ia32 && $mode == debug ]
301297
dart/*: Pass, Slow # The CFE is not run from AppJit snapshot, JIT warmup in debug mode very slow
302298
dart_2/*: Pass, Slow # The CFE is not run from AppJit snapshot, JIT warmup in debug mode very slow

‎tests/language/language_precompiled.status

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -3,10 +3,6 @@
33
# BSD-style license that can be found in the LICENSE file.
44
# Sections in this file should start with "$runtime == dart_precompiled".
55

6-
[ $arch == arm64 && $runtime == dart_precompiled ]
7-
class/large_class_declaration_test: SkipSlow # Uses too much memory.
8-
setter/setter4_test: MissingCompileTimeError
9-
106
[ $arch == ia32 && $runtime == dart_precompiled ]
117
vm/regress_24517_test: Pass, Fail # Issue 24517.
128

‎tests/language/language_vm.status

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -16,10 +16,6 @@ assert/initializer_const_error2_test/cc09: MissingCompileTimeError # Not reporti
1616
assert/initializer_const_error2_test/cc10: MissingCompileTimeError # Not reporting failed assert() at compile time.
1717
assert/initializer_const_error2_test/cc11: MissingCompileTimeError # Not reporting failed assert() at compile time.
1818

19-
[ $arch == arm64 && $runtime == vm ]
20-
class/large_class_declaration_test: SkipSlow # Uses too much memory.
21-
closure/cycles_test: Pass, Slow
22-
2319
[ $arch == ia32 && $mode == release && $runtime == vm ]
2420
syntax/deep_nesting_expression_test/01: Crash, Pass # Issue 31496
2521

‎tests/language_2/language_2_precompiled.status

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -3,10 +3,6 @@
33
# BSD-style license that can be found in the LICENSE file.
44
# Sections in this file should start with "$runtime == dart_precompiled".
55

6-
[ $arch == arm64 && $runtime == dart_precompiled ]
7-
class/large_class_declaration_test: SkipSlow # Uses too much memory.
8-
setter/setter4_test: MissingCompileTimeError
9-
106
[ $arch == ia32 && $runtime == dart_precompiled ]
117
vm/regress_24517_test: Pass, Fail # Issue 24517.
128

‎tests/language_2/language_2_vm.status

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -16,10 +16,6 @@ assert/initializer_const_error2_test/cc09: MissingCompileTimeError # Not reporti
1616
assert/initializer_const_error2_test/cc10: MissingCompileTimeError # Not reporting failed assert() at compile time.
1717
assert/initializer_const_error2_test/cc11: MissingCompileTimeError # Not reporting failed assert() at compile time.
1818

19-
[ $arch == arm64 && $runtime == vm ]
20-
class/large_class_declaration_test: SkipSlow # Uses too much memory.
21-
closure/cycles_test: Pass, Slow
22-
2319
[ $arch == ia32 && $mode == release && $runtime == vm ]
2420
syntax/deep_nesting_expression_test/01: Crash, Pass # Issue 31496
2521

‎tests/lib/lib_vm.status

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -5,9 +5,6 @@
55
[ $runtime != vm ]
66
isolate/native_wrapper_message_test: Skip # A VM specific test.
77

8-
[ $arch == arm64 && $runtime == vm ]
9-
mirrors/immutable_collections_test: Pass, Slow # http://dartbug.com/33057
10-
118
[ $arch == ia32 && $mode == debug && $runtime == vm && $system == windows ]
129
convert/streamed_conversion_json_utf8_decode_test: Skip # Verification OOM.
1310

‎tests/lib_2/lib_2_vm.status

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -5,9 +5,6 @@
55
[ $runtime != vm ]
66
isolate/native_wrapper_message_test: Skip # A VM specific test.
77

8-
[ $arch == arm64 && $runtime == vm ]
9-
mirrors/immutable_collections_test: Pass, Slow # http://dartbug.com/33057
10-
118
[ $compiler != app_jitk && $compiler != dartk && $runtime == vm ]
129
async/future_or_only_in_async_test/00: MissingCompileTimeError
1310
convert/streamed_conversion_json_utf8_decode_test: Pass, Slow # Infrequent timeouts.

‎tests/standalone/standalone_vm.status

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -69,10 +69,3 @@ io/named_pipe_script_test: Skip # Issue 28737
6969
io/dart_std_io_pipe_test: Timeout, Pass
7070
io/http_client_stays_alive_test: Skip # Spawns process in Dart2 mode.
7171
io/process_sync_test: Timeout, Pass
72-
73-
[ $runtime == vm && ($arch == arm || $arch == arm64) ]
74-
io/dart_std_io_pipe_test: Timeout, Pass
75-
io/file_input_stream_test: Skip # Issue 26109
76-
io/file_stream_test: Skip # Issue 26109
77-
io/file_typed_data_test: Skip # Issue 26109
78-
io/process_sync_test: Timeout, Pass

‎tests/standalone_2/standalone_2_vm.status

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -70,10 +70,3 @@ io/named_pipe_script_test: Pass, RuntimeError # Issue 28737
7070
io/dart_std_io_pipe_test: Timeout, Pass
7171
io/http_client_stays_alive_test: Skip # Spawns process in Dart2 mode.
7272
io/process_sync_test: Timeout, Pass
73-
74-
[ $runtime == vm && ($arch == arm || $arch == arm64) ]
75-
io/dart_std_io_pipe_test: Timeout, Pass
76-
io/file_input_stream_test: Skip # Issue 26109
77-
io/file_stream_test: Skip # Issue 26109
78-
io/file_typed_data_test: Skip # Issue 26109
79-
io/process_sync_test: Timeout, Pass

0 commit comments

Comments
 (0)