Skip to content

SelectElement's 'void add(Element element, Element before)' does not allow 'before' to be null. #2583

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ghost opened this issue Apr 16, 2012 · 5 comments
Assignees
Labels
web-libraries Issues impacting dart:html, etc., libraries
Milestone

Comments

@ghost
Copy link

ghost commented Apr 16, 2012

Passing null as 'before' should add the option element in front of the list:

SelectElement select = ...
select.add(new OptionElement("hey"), null);

Instead it throws an exception inside HTMLSelectElementImplementation.add:
Invalid class: expected instance HTMLElementImplementation

See also: http://api.dartlang.org/dom/HTMLSelectElement.html

@ghost
Copy link
Author

ghost commented Apr 16, 2012

A workaround is:

select.elements.add(new OptionElement(".."));

@vsmenon
Copy link
Member

vsmenon commented Jul 12, 2012

Should we remove this method?


Added this to the M1 milestone.

@iposva-google
Copy link
Contributor

Removed Area-DOM label.
Added Area-HTML label.

@blois
Copy link

blois commented Sep 6, 2012

Set owner to @blois.
Added Accepted label.

@blois
Copy link

blois commented Sep 7, 2012

I've removed the add method- the element collection should be used directly.


Added Fixed label.

@ghost ghost added Type-Defect web-libraries Issues impacting dart:html, etc., libraries labels Sep 7, 2012
@ghost ghost assigned blois Sep 7, 2012
@ghost ghost added this to the M1 milestone Sep 7, 2012
dart-bot pushed a commit that referenced this issue Aug 11, 2020
> git log --oneline 04b054b62cc437cf23451785fdc50e49cd9de139..master
0d185a39 (HEAD -> master, origin/master, origin/HEAD) Push null-safety forwards to 2.11 (#2604)
56f9f27f Hide outdated --mode flag (#2603)
61ce6f81 Avoid double loop (#2605)
fa6e57d7 (disable_mixed_mode_validation) Fix outdated latest ordering (#2598)
6549e4aa Remove unused dependency from pubspec.yaml (#2592)
61543d07 Don't look for external package foo during testing (#2599)
590b448f Fixed license headers (#2595)
04e0601e Don't show entries for dev-dependencies in outdated --json --no-dev-dependencies (#2591)
8c3778c4 Configure GitHub move app (#2578)
eec7beca (top_level_command) Pass --(no-)sound-null-safety arg through to VM. (#2542)
152e4740 Warn about publishing in mixed mode (#2583)
0b7a3abe Removed april fools toys (#2325)
b74a5b73 Actually print hints (#2582)
8ec3a66d (pub2) Fix outdated --no-color (#2572)
7bb3d4e6 Use getSdkPath() in NullSafetyAnalysis (#2573)
3c578f24 Drop the "magic" package concept (#2577)
0e967ff0 Remove unused function (#2570)
988fefef Remove dependency overrides (#2568)

Change-Id: I58bf14234ed55bf9d825de60a40ded1d65281195
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/158003
Reviewed-by: Jonas Jensen <[email protected]>
Commit-Queue: Sigurd Meldgaard <[email protected]>
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
web-libraries Issues impacting dart:html, etc., libraries
Projects
None yet
Development

No branches or pull requests

3 participants