Skip to content

implement configuration specific imports #27302

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
vsmenon opened this issue Sep 13, 2016 · 11 comments
Closed

implement configuration specific imports #27302

vsmenon opened this issue Sep 13, 2016 · 11 comments
Assignees
Labels
P1 A high priority bug; for example, a single project is unusable or has many test failures web-dev-compiler
Milestone

Comments

@vsmenon
Copy link
Member

vsmenon commented Sep 13, 2016

From @jmesserly on June 22, 2016 23:36

See SDK bug: #24581

Guessing this should be pretty easy, mostly plumbing through the right configuration to Analyzer.

CC @alan-knight

Copied from original issue: dart-archive/dev_compiler#595

@vsmenon vsmenon added web-dev-compiler P2 A bug or feature request we're likely to work on labels Sep 13, 2016
@vsmenon
Copy link
Member Author

vsmenon commented Sep 13, 2016

From @anders-sandholm on September 13, 2016 10:53

When do you expect to see this land?

Would be great to get this landed. Look's like this might be the last bit missing in enabling a re-write of package http to use config-specific imports instead of mirrors.

@vsmenon
Copy link
Member Author

vsmenon commented Sep 13, 2016

Not scheduled yet.

@mit-mit
Copy link
Member

mit-mit commented Oct 7, 2016

Any news here? We now have actual usage of this in the SDK; see package resource.

Updating to P1.

@mit-mit mit-mit added P1 A high priority bug; for example, a single project is unusable or has many test failures and removed P2 A bug or feature request we're likely to work on labels Oct 7, 2016
@vsmenon
Copy link
Member Author

vsmenon commented Oct 7, 2016

This should fixed by #27511 ( @bwilkerson - is there anything more?) - I'll up that to P1 as well.

@bwilkerson
Copy link
Member

Not that I know of, except that there is now discussion of de-scoping configuration specific imports.

@vsmenon
Copy link
Member Author

vsmenon commented Dec 13, 2016

@munificent - not sure what the status of this is. It might just work. @jmesserly plumbed some support for defined variables recently. Do we need this for 1.5 or earlier?

@mit-mit
Copy link
Member

mit-mit commented Dec 13, 2016

We need this for 1.22; Flutter also needs it now.

@munificent
Copy link
Member

@munificent - not sure what the status of this is.

Me either. I handed it off to @floitschG ages ago.

Do we need this for 1.5 or earlier?

No, it's not a 1.5 milestone language issue.

@mit-mit
Copy link
Member

mit-mit commented Dec 14, 2016

No, it's not a 1.5 milestone language issue.

Correct. This pre-dates 1.50, and should have been completed long ago. Can we please just get this done now?

CC @dgrove in case additional discussion is needed.

@mit-mit mit-mit added this to the 1.22 milestone Dec 14, 2016
@dgrove
Copy link
Contributor

dgrove commented Dec 14, 2016 via email

@vsmenon
Copy link
Member Author

vsmenon commented Dec 14, 2016

Just tried it. It basically already works. This makes it more useful:

https://codereview.chromium.org/2578573003/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P1 A high priority bug; for example, a single project is unusable or has many test failures web-dev-compiler
Projects
None yet
Development

No branches or pull requests

5 participants