Testing shared options

[peter-ahe-google]

There is a number of options that should be supported by most of our Dart implementations:

* setting the package root.

* turning on checked mode (aka developer mode).

* turning on assertions.

We need to be able to test these options, and we need to agree on the "command line syntax" for these options. This bug is about testing the options, not the concrete command line syntax.

Bill and I discussed this and we think it could be implemented by adding a tag similar to VMOptions, but unlike VMOptions, these options would be expected to be understood by all implementations, and it would be a test failure to reject an option (so this is not compatible with --ignore-unrecognized-options).

For example, to test an option for setting the package root, lets assume --package-root=<path> could look like this:

my_test.dart:
// DartOptions=--package-root=my_test_package_root

import('package:foo.dart', prefix: 'foo');

main() {
  Expect.equals(42, foo.x);
}

my_test_package_root/foo.dart
var x = 42;

And a negative test could look like this:
my_negative_test.dart
// DartOptions=--package-root=no_such_directory
main() {}

[whesse]

I think I misunderstood - I thought that options would be a command-line option for the test.dart (test.py) program:
test.py --compiler=dart2js --runtime=d8 --options="--package-root=my_test_package_root"

Or are you suggesting that both features be added?

[peter-ahe-google]

I do not want a command line option to test.py/test.dart.

[whesse]

Added this to the Later milestone.

[peter-ahe-google]

I think we need to test this for M1.

---

Removed this from the Later milestone.
Added this to the M1 milestone.

[peter-ahe-google]

Marked this as blocking #3170.

[whesse]

Do we always want the options specified by an Options= line to go to the "dart" part of the component, so to the dart or DRT executable if compiler=none, and to the compiler otherwise?

I think the name /// Options= would be as good as DartOptions.

[dgrove]

Removed this from the M1 milestone.
Added this to the M2 milestone.

[peter-ahe-google]

Removed this from the M2 milestone.
Added this to the M3 milestone.

[peter-ahe-google]

Removed this from the M3 milestone.
Added this to the M4 milestone.

[larsbak]

Removed this from the M4 milestone.
Added this to the M5 milestone.

[kasperl]

Removed this from the M5 milestone.
Added this to the 1.6 milestone.

[kasperl]

Removed this from the 1.6 milestone.
Added Oldschool-Milestone-1.6 label.

[kasperl]

Removed Oldschool-Milestone-1.6 label.

[matanlurey]

Most of these options no longer exist in Dart2.