Skip to content

2.0.0-dev.41.0 contains broken pub (can not fetch packages) #32655

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jcollins-g opened this issue Mar 23, 2018 · 6 comments
Closed

2.0.0-dev.41.0 contains broken pub (can not fetch packages) #32655

jcollins-g opened this issue Mar 23, 2018 · 6 comments
Assignees

Comments

@jcollins-g
Copy link
Contributor

This issue made it into the pub in that release: dart-lang/pub#1846

Can we add a sanity check to make sure pub can fetch packages? It's quite time consuming to debug, pin my Travis, wait for a non-broken SDK, then unpin again.

@jcollins-g
Copy link
Contributor Author

jcollins-g commented Mar 23, 2018

To be clear, I'm suggesting a sanity check for this in the SDK prior to building a release version. It should be entirely possible for pub to transiently have even critical failures in development, that's normal, it's just sad to have them escape into the wild. :-(

@kevmoo
Copy link
Member

kevmoo commented Mar 23, 2018

See #32651

@kevmoo
Copy link
Member

kevmoo commented Mar 23, 2018

@kevmoo
Copy link
Member

kevmoo commented Mar 23, 2018

fix landed in 0b2684e

@jcollins-g
Copy link
Contributor Author

Great that the base issue is addressed, but I'd like to leave this open to track adding some sort of integration test to prevent this from happening again. In other words, this bug is open because bugs like this can reappear at any time.

@jcollins-g
Copy link
Contributor Author

Closing -> integration test is covered by #32656

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants