Skip to content

SDK tests must validate pub get/upgrade #32656

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
kevmoo opened this issue Mar 23, 2018 · 7 comments
Closed

SDK tests must validate pub get/upgrade #32656

kevmoo opened this issue Mar 23, 2018 · 7 comments
Assignees
@athomas
Labels
area-infrastructure Use area-infrastructure for SDK infrastructure issues, like continuous integration bot changes. area-test Cross-cutting test issues (use area- labels for specific failures; not used for package:test). P2 A bug or feature request we're likely to work on
Milestone
Dart2Beta4

Comments

@kevmoo
Copy link
Member

kevmoo commented Mar 23, 2018

RE #32655 snafu
@kevmoo kevmoo added area-test Cross-cutting test issues (use area- labels for specific failures; not used for package:test). P0 A serious issue requiring immediate resolution area-infrastructure Use area-infrastructure for SDK infrastructure issues, like continuous integration bot changes. labels Mar 23, 2018
@kevmoo kevmoo added this to the Dart2 Beta 3 milestone Mar 23, 2018
@jcollins-g jcollins-g mentioned this issue Mar 23, 2018
Closed
@dgrove
Copy link
Contributor

dgrove commented Mar 23, 2018

This isn't a P0, but it is something we need to address.

@dgrove dgrove added P1 A high priority bug; for example, a single project is unusable or has many test failures and removed P0 A serious issue requiring immediate resolution labels Mar 23, 2018
@matanlurey
Copy link
Contributor

I opened a similar bug (and got it closed) a while ago.

I realize we are "moving fast and breaking things", but I think at some point we need to have release verification, not just an automatic process of pushing releases without end to end testing for core functionality.

@dgrove
Copy link
Contributor

dgrove commented Mar 23, 2018 via email

@dgrove dgrove modified the milestones: Dart2 Beta 3, Dart2 Beta 4 Mar 24, 2018
@athomas
Copy link
Member

athomas commented Apr 16, 2018 •
edited
Loading

Breakdown after brief chat with @kevmoo:

  • Migrate pkg builders to the test matrix
  • Add step(s) to pub get/pub upgrade package:shelf or test

@athomas
Copy link
Member

athomas commented Apr 19, 2018 •
edited
Loading

Status update:

  • Moved the pkg builders to the test matrix, that makes it easier for me to proceed.
  • Built a prototype for the pkg integration test: works but is a bit hackish.
  • Running pub is required to run scripts to release the SDK, when I built 2.0.0.49-dev I used the pub from the SDK to publish it. I will keep doing that until there is a test for this.

@JekCharlsonYu JekCharlsonYu added P2 A bug or feature request we're likely to work on and removed P1 A high priority bug; for example, a single project is unusable or has many test failures labels Apr 24, 2018
@dgrove
Copy link
Contributor

dgrove commented May 8, 2018

Any further updates on this?

@athomas
Copy link
Member

athomas commented May 9, 2018

Status update:

  • Discussed prototype with @whesse: I have a few issues to fix before I can land it.

dart-bot pushed a commit that referenced this issue May 15, 2018
@athomas
[infra] Add .bat to pub command on Windows
2d5c106 
#32656

Change-Id: I3a34bf2c81676eea0ab112a8aad701962590a6c3
Reviewed-on: https://dart-review.googlesource.com/55165
Commit-Queue: Alexander Thomas <[email protected]>
Reviewed-by: William Hesse <[email protected]>
dart-bot pushed a commit that referenced this issue Jan 10, 2019
@athomas
[infra] Migrate pkg builders to Luci
09af50c 
* Switch CQ builder to neo.py.

#32656

Change-Id: I0e4b3e7e1427dd87eeabb7662129083edc2678b5
Reviewed-on: https://dart-review.googlesource.com/51461
Reviewed-by: Jonas Termansen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@athomas athomas

Labels
area-infrastructure Use area-infrastructure for SDK infrastructure issues, like continuous integration bot changes. area-test Cross-cutting test issues (use area- labels for specific failures; not used for package:test). P2 A bug or feature request we're likely to work on
Projects
None yet
Milestone
Dart2Beta4
Development

No branches or pull requests
5 participants
@kevmoo @matanlurey @dgrove @athomas @JekCharlsonYu