Skip to content

html/indexeddb_3_test is failing in dart2js_drt_release_ia32 on Mac #3670

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
peter-ahe-google opened this issue Jun 15, 2012 · 8 comments
Closed
Labels
closed-obsolete Closed as the reported issue is no longer relevant web-libraries Issues impacting dart:html, etc., libraries

Comments

@peter-ahe-google
Copy link
Contributor

Content-Type: text/plain
FAIL
1 PASS Expectation: prepare.
2 PASS Expectation: readAll1.
3 FAIL Expectation: readAll2. Caught Error: DataError: DOM IDBDatabase Exception 5
Error: The data provided does not meet requirements.
    at IDBObjectStore.$.$defineNativeClass.openCursor$2 (file:///Users/ahe/Dart/all/dart/xcodebuild/ReleaseIA32/generated_tests/dart2js-drt/tests_html_indexeddb_3_test/test.js:6313:15)
    at IDBObjectStore.nullCheckMethod (file:///Users/ahe/Dart/all/dart/xcodebuild/ReleaseIA32/generated_tests/dart2js-drt/tests_html_indexeddb_3_test/test.js:4907:55)
    at Function.$.dynamicBind as $call$4
    at IDBObjectStore.bind (file:///Users/ahe/Dart/all/dart/xcodebuild/ReleaseIA32/generated_tests/dart2js-drt/tests_html_indexeddb_3_test/test.js:4709:48)
    at Test.$$.Test.readAllReversedViaCursor$0 (file:///Users/ahe/Dart/all/dart/xcodebuild/ReleaseIA32/generated_tests/dart2js-drt/tests_html_indexeddb_3_test/test.js:1167:87)
    at Closure45.Isolate.$defineClass.$call$0 (file:///Users/ahe/Dart/all/dart/xcodebuild/ReleaseIA32/generated_tests/dart2js-drt/tests_html_indexeddb_3_test/test.js:3299:52)
    at TestCase.$$.TestCase.test$0 (file:///Users/ahe/Dart/all/dart/xcodebuild/ReleaseIA32/generated_tests/dart2js-drt/tests_html_indexeddb_3_test/test.js:1299:40)
    at Closure31.$$.Closure31.$call$0 (file:///Users/ahe/Dart/all/dart/xcodebuild/ReleaseIA32/generated_tests/dart2js-drt/tests_html_indexeddb_3_test/test.js:3157:19)
    at $.guardAsync (file:///Users/ahe/Dart/all/dart/xcodebuild/ReleaseIA32/generated_tests/dart2js-drt/tests_html_indexeddb_3_test/test.js:5134:20)
    at Function.$._nextBatch as $call$0
Total 2 passed, 1 failed 0 errors

EOF

@peter-ahe-google
Copy link
Contributor Author

I think it is likely that this is a problem with dart2js or DRT.

I would appreciate if someone familiar with the test could do the initial evaluation, and assign it back to dart2js if (when) it is determined to be a dart2js bug.

@rakudrama
Copy link
Member

Do you know when this started to fail, i.e. which CL broke it?

@peter-ahe-google
Copy link
Contributor Author

Sorry, no. This problem has been there a while, and I should have reported it earlier. I'll bisect on Monday.


Set owner to @peter-ahe-google.

@peter-ahe-google
Copy link
Contributor Author

I'm not sure that this test has ever worked. It is disabled in other configurations:

[ $compiler == none && ($runtime == drt || $runtime == dartium) ]
indexeddb_3_test: Fail # Temporary disable after recent webkit roll.

[ $runtime == ff ]
indexeddb_3_test: Fail # Need window.mozIndexedDB instead of window.webkitIndexedDB

[ $compiler == dart2js && ($runtime == drt || $runtime == ff) && $system == linux]
indexeddb_3_test: Fail # Caught Error: DATA_ERR: DOM IDBDatabase Exception 5 Error: The data provided does not meet the requirements of the function.

[ $compiler == dart2js && $runtime == chrome ]

TODO(sra): Triage incompatibility issue.

indexeddb_3_test: Fail # DATA_ERR: DOM IDBDatabase Exception 5 Error: The data provided does not meet the requirements of the function.

In particular, the comment for $system == linux above is "Caught Error: DATA_ERR: DOM IDBDatabase Exception 5 Error: The data provided does not meet the requirements of the function." This looks remarkably similar to what I see on my Mac.


Removed the owner.

@rakudrama
Copy link
Member

"I'm not sure that this test has ever worked. It is disabled in other configurations"

This test did run when I first wrote it.
The error has changed over time.

@peter-ahe-google
Copy link
Contributor Author

I'm not sure this test ever worked with dart2js, is what I meant.

The test is marked failing on Linux. The configuration Mac/drt/dart2js is not tested on the build bot, so I assumed this configuration has never been tested. If you can give me a revision to start at, I'll be happy to try bisecting, but I don't know where to start.

@iposva-google
Copy link
Contributor

Removed Area-DOM label.
Added Area-HTML label.

@vsmenon
Copy link
Member

vsmenon commented Aug 17, 2012

It appears to be working now.


Added AssumedStale label.

@peter-ahe-google peter-ahe-google added Type-Defect web-libraries Issues impacting dart:html, etc., libraries closed-obsolete Closed as the reported issue is no longer relevant labels Aug 17, 2012
copybara-service bot pushed a commit that referenced this issue Nov 29, 2022
Changes:
```
> git log --format="%C(auto) %h %s" 6fdcdd4..867ad17
 https://dart.googlesource.com/pub.git/+/867ad175 Fix reading pubspecs from git (#3670)

```

Diff: https://dart.googlesource.com/pub.git/+/6fdcdd4357645817e7d7027ee2157ed68ef69c53~..867ad175d81713c4e70473b1ab32107547cbdc3e/
Bug: flutter/flutter#116107
Change-Id: I6b1a2f1e4f1864c9a2658568f6dfd63383d10406
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/272620
Commit-Queue: Siva Annamalai <[email protected]>
Reviewed-by: Martin Kustermann <[email protected]>
Reviewed-by: Jonas Jensen <[email protected]>
Commit-Queue: Sigurd Meldgaard <[email protected]>
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
closed-obsolete Closed as the reported issue is no longer relevant web-libraries Issues impacting dart:html, etc., libraries
Projects
None yet
Development

No branches or pull requests

4 participants