Skip to content

Implement "experiment release versions" in the analyzer #43032

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jakemac53 opened this issue Aug 12, 2020 · 3 comments
Closed

Implement "experiment release versions" in the analyzer #43032

jakemac53 opened this issue Aug 12, 2020 · 3 comments
Assignees
@scheglov
Labels
legacy-area-analyzer Use area-devexp instead. NNBD Issues related to NNBD Release P1 A high priority bug; for example, a single project is unusable or has many test failures
Milestone
September Release...

Comments

@jakemac53
Copy link
Contributor

See the meta issue #43031
@jakemac53 jakemac53 added P1 A high priority bug; for example, a single project is unusable or has many test failures legacy-area-analyzer Use area-devexp instead. NNBD Issues related to NNBD Release labels Aug 12, 2020
@jakemac53 jakemac53 mentioned this issue Aug 12, 2020
Closed
7 tasks
@jakemac53 jakemac53 added this to the September Release 2020 milestone Aug 12, 2020
dart-bot pushed a commit that referenced this issue Aug 19, 2020
@scheglov
Update FeatureSet to the new rules.
2b7fc8f 
Bug: #43032
Change-Id: I6c7d7dc56fd0d4edcc3c6f6cc6fb0422316b8f4c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/159187
Reviewed-by: Brian Wilkerson <[email protected]>
Commit-Queue: Konstantin Shcheglov <[email protected]>
@scheglov
Copy link
Contributor

Implementation in the analyzer is landed, but experimental_features.yaml needs to be updated, so that we can fill experimentalReleaseVersion field for features.

@jakemac53 I don't see the corresponding item in #43031, should we give some version to non-nullable?

@scheglov
Copy link
Contributor

https://dart-review.googlesource.com/c/sdk/+/159383 will update experimental_features.yaml.

@jakemac53
Copy link
Contributor Author

2.10 is the expected version, I added a line item list to the meta issue but didn't create another github issue given that you already have a cl out

dart-bot pushed a commit that referenced this issue Aug 20, 2020
@scheglov
Update experimental_features.yaml, set experimentalReleaseVersion for…
39e4dfe 
… non-nullable.

Bug: #43032
Change-Id: I28b27b3416826abd807a185b2d4214782571fb98
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/159383
Commit-Queue: Konstantin Shcheglov <[email protected]>
Reviewed-by: Paul Berry <[email protected]>
Reviewed-by: Jake Macdonald <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@scheglov scheglov

Labels
legacy-area-analyzer Use area-devexp instead. NNBD Issues related to NNBD Release P1 A high priority bug; for example, a single project is unusable or has many test failures
Projects
None yet
Milestone
September Release 2020
Development

No branches or pull requests
2 participants
@scheglov @jakemac53