Skip to content

[ddc] Migrate pkg/dev_compiler to null safety #46617

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Tracked by #49169
nshahan opened this issue Jul 14, 2021 · 1 comment
Closed
Tracked by #49169

[ddc] Migrate pkg/dev_compiler to null safety #46617

nshahan opened this issue Jul 14, 2021 · 1 comment
Assignees
@nshahan
Labels
area-web-js Issues related to JavaScript support for Dart Web, including DDC, dart2js, and JS interop. P3 A lower priority bug or feature request web-dev-compiler web-triage-1 priority assigned

Comments

@nshahan
Copy link
Contributor

nshahan commented Jul 14, 2021

Tracking issue for the process of migrating all dev_compiler libraries to null safety.
@nshahan nshahan added P3 A lower priority bug or feature request web-dev-compiler area-web-js Issues related to JavaScript support for Dart Web, including DDC, dart2js, and JS interop. labels Jul 14, 2021
@nshahan nshahan self-assigned this Jul 14, 2021
dart-bot pushed a commit that referenced this issue Jul 15, 2021
@nshahan
[ddc] Bump minimum sdk version
dbfbc7e 
Preparation to begin migrating dev_compiler libraries to null safety.
With this change any file we remove the old language version comment
from will be opted into null safety.

Change-Id: I567d139a6c6bfa0b8f820b16e3eb87a2f49228b3
Issue: #46617
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/206961
Reviewed-by: Sigmund Cherem <[email protected]>
Commit-Queue: Nicholas Shahan <[email protected]>
dart-bot pushed a commit that referenced this issue Jul 20, 2021
@nshahan
[ddc] Update webkit_inspection_protocol dep
9cf61ba 
- New version has been migrated to null safety.
- Update tests that are currently broken. It looks like a CFE bug
  was fixed and now the private static fields are accessible.

Change-Id: I3d9bde85b65c0e219f756df2d9531539eb7f732b
Issue: #46617
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/207382
Reviewed-by: Mark Zhou <[email protected]>
Commit-Queue: Nicholas Shahan <[email protected]>
dart-bot pushed a commit that referenced this issue Jul 23, 2021
@nshahan
[ddc] Bump browser_launcher dep to v1.0.0
5668791 
- Supports sound null safety.

Change-Id: I5778d1e0b47b97a24f7433509963f945d702d6b2
Issue: #46617
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/207920
Reviewed-by: Mark Zhou <[email protected]>
Commit-Queue: Nicholas Shahan <[email protected]>
dart-bot pushed a commit that referenced this issue Aug 17, 2021
@nshahan
[dart2js] Migrate dart2js_tools to null safety
4b1de45 
Change-Id: If93f66f4da2dafb50f58434eb112b1f8af6648c7
Issue: #46617
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/208363
Commit-Queue: Nicholas Shahan <[email protected]>
Reviewed-by: Stephen Adams <[email protected]>
dart-bot pushed a commit that referenced this issue Aug 19, 2021
@nshahan
Revert "[dart2js] Migrate dart2js_tools to null safety"
9ae8713 
This reverts commit 4b1de45.

Reason for revert: Null safety error appears when test fail:
error: Null check operator used on a null value

Original change's description:
> [dart2js] Migrate dart2js_tools to null safety
>
> Change-Id: If93f66f4da2dafb50f58434eb112b1f8af6648c7
> Issue: #46617
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/208363
> Commit-Queue: Nicholas Shahan <[email protected]>
> Reviewed-by: Stephen Adams <[email protected]>

# Not skipping CQ checks because original CL landed > 1 day ago.

Issue: #46617
Change-Id: I7ef7d95a6715d667698e0dfcb38375fd79b4cc73
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/210540
Reviewed-by: Stephen Adams <[email protected]>
Commit-Queue: Nicholas Shahan <[email protected]>
@nshahan nshahan mentioned this issue Sep 3, 2021
Closed
copybara-service bot pushed a commit that referenced this issue Oct 5, 2021
@nshahan
[ddc] Migrate module_metadata to null safety
198dc43 
* Migrate the library and tests.
* Update comments per effective dart recommendations.

Change-Id: Ibc8da1fe68c977fb3c084208b96734354ad2705b
Issue: #46617
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/215122
Reviewed-by: Anna Gringauze <[email protected]>
Commit-Queue: Nicholas Shahan <[email protected]>
@nshahan nshahan added the web-triage-1 priority assigned label Oct 7, 2021
copybara-service bot pushed a commit that referenced this issue Oct 7, 2021
@nshahan
[web] Bump source_maps dep to v0.10.10
c7e1276 
The current version points to a commit for v0.11.0-nullsafety.
It looks like a 0.11.0 release was never actually published. A
null safe version of the package was actually published as v0.10.10.

This also makes the version number in the package:dart2js_tools
pubspec match the version in the deps file.

Change-Id: Ibf495ed5e7388370b5cf950ed3559bf7749f42b9
Issue: #46617
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/215982
Reviewed-by: Sigmund Cherem <[email protected]>
Commit-Queue: Nicholas Shahan <[email protected]>
copybara-service bot pushed a commit that referenced this issue Oct 9, 2021
@nshahan
[dart2js] Migrate dart2js_tools to null safety
50fb0c6 
Change-Id: I43186c26521eca6405d0ab8b3a50b545a91b5cc2
Issue: #46617
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/215013
Reviewed-by: Sigmund Cherem <[email protected]>
Commit-Queue: Nicholas Shahan <[email protected]>
copybara-service bot pushed a commit that referenced this issue Dec 10, 2021
@nshahan
[ddc] Enable null safety in module_symbols library
427c833 
Also migrate the library test and the module_symbols_collector library.

Change-Id: Id00ac050e8f36ed7016b6d1d49b10fa4297aaeb6
Issue: #46617
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/216760
Reviewed-by: Anna Gringauze <[email protected]>
Commit-Queue: Nicholas Shahan <[email protected]>
copybara-service bot pushed a commit that referenced this issue Dec 13, 2021
@nshahan
[ddc] Migrate native_types to null safety
9a0400b 
Change-Id: I9e169000855fafc3ae11389818ceefc374cc2af4
Issue: #46617
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/223361
Reviewed-by: Srujan Gaddam <[email protected]>
Commit-Queue: Nicholas Shahan <[email protected]>
copybara-service bot pushed a commit that referenced this issue Dec 14, 2021
@nshahan
[ddc] Migrate js_interop library to null safety
0868f39 
Change-Id: Ic08b68dcc50e22826203efdc491f7d56dc95ec2b
Issue: #46617
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/223363
Reviewed-by: Srujan Gaddam <[email protected]>
Commit-Queue: Nicholas Shahan <[email protected]>
copybara-service bot pushed a commit that referenced this issue Dec 14, 2021
@nshahan
[ddc] Migrate js_typerep libraries to null safety
d33e94f 
Change-Id: I73a1f7da1c62bc12d832da7d22a5288425ee99aa
Issue: #46617
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/223362
Reviewed-by: Mark Zhou <[email protected]>
Commit-Queue: Nicholas Shahan <[email protected]>
copybara-service bot pushed a commit that referenced this issue Jan 10, 2022
@nshahan
[ddc] Migrate AssetFileSystem to null safety
8ac8789 
Change-Id: Icf79bb882a863e333cc30620a1b0a5154763cdd0
Issue: #46617
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/223280
Reviewed-by: Anna Gringauze <[email protected]>
Commit-Queue: Nicholas Shahan <[email protected]>
copybara-service bot pushed a commit that referenced this issue Mar 24, 2022
@nshahan
[ddc] Break SwitchCase into Case and Default nodes
a34c8a6 
- Removes another diff between this version and the package:js_ast.
- This is helpful for the null safety migration as the expression
  in the Case node can now be non-nullable.

Change-Id: Ia6626b2ee8a4e8b66bc6b53ea74d16d2d9f81f7a
Issue: #46617
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/238663
Reviewed-by: Stephen Adams <[email protected]>
Commit-Queue: Nicholas Shahan <[email protected]>
copybara-service bot pushed a commit that referenced this issue Mar 28, 2022
@nshahan
[ddc] Migrate js_ast libraries to null safety
5d184a7 
- characters.dart
- nodes.dart
- precedence.dart
- printer.dart

Change-Id: I038d2ea9f8a265123c34de92723078df53e5e4fe
Issue: #46617
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/238960
Reviewed-by: Stephen Adams <[email protected]>
Commit-Queue: Nicholas Shahan <[email protected]>
copybara-service bot pushed a commit that referenced this issue Mar 29, 2022
@nshahan
[ddc] Migrate js_ast libraries to null safety
4193c18 
- builder.dart
- template.dart

Change-Id: Ie399e7e5ba3261dea36d5139239ddc3d014981f9
Issue: #46617
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/239222
Reviewed-by: Stephen Adams <[email protected]>
Commit-Queue: Nicholas Shahan <[email protected]>
copybara-service bot pushed a commit that referenced this issue Mar 30, 2022
@nshahan
[ddc] Remove more diffs with pkg/js_ast
ba4e18b 
- Remove lint ignores and cleanup violations when they are either
  in code that doesn't exist in or are already fixed in the pkg/js_ast
  version.
- Migrate the builder_test.dart (the small test file).

Issue: #46617
Change-Id: I1083235de93f028e5f338180b97308f52a45f17f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/239363
Reviewed-by: Stephen Adams <[email protected]>
Commit-Queue: Nicholas Shahan <[email protected]>
copybara-service bot pushed a commit that referenced this issue Apr 1, 2022
@nshahan
[ddc] Migrate source_map_printer to null safety
74caf5f 
Change-Id: I89826ba3af91f1392d6291b008b41af94c0072b1
Issue: #46617
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/239585
Reviewed-by: Mark Zhou <[email protected]>
Commit-Queue: Nicholas Shahan <[email protected]>
copybara-service bot pushed a commit that referenced this issue Apr 1, 2022
@nshahan
[ddc] Migrate js_names and js_utils to null safety
ff3e340 
Change-Id: I187c547d9922185dd20db3e773eb4c8fbe7ec0a6
Issue: #46617
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/239544
Reviewed-by: Stephen Adams <[email protected]>
Commit-Queue: Nicholas Shahan <[email protected]>
copybara-service bot pushed a commit that referenced this issue May 13, 2022
@nshahan
[ddc] Migrate type_table to null safety
b62b76b 
Change-Id: I3e4da0d6031860e8538a6d7e650eff6f7ab76155
Issue: #46617
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/244262
Reviewed-by: Mark Zhou <[email protected]>
Commit-Queue: Nicholas Shahan <[email protected]>
copybara-service bot pushed a commit that referenced this issue May 13, 2022
@nshahan
[ddc] Migrate modular test suite runners to null safety
44f8583 
- Migrate the test runner suites to null safety.
- Cleanup old "non-nullable" experiment flags
- Force null safety mode in the two suites:
  - modular_suite.dart: weak null safety
  - modular_suite_nnbd.dart: sound null safety
  NOTE: in both cases the source code is treated as null safe code.
  There are no tests written in a legacy dart version.

Change-Id: I19ec25f7b5abc712971771a193c02ebd5283b987
Fixes: #43096
Issue: #46617
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/244500
Reviewed-by: Sigmund Cherem <[email protected]>
Commit-Queue: Nicholas Shahan <[email protected]>
copybara-service bot pushed a commit that referenced this issue May 25, 2022
@nshahan
[web] Migrate sourcemap_testing to null safety
19959e3 
Change-Id: Id89be7e1327d7e9016fcd7d2864d124bc04d865a
Issue: #46617
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/243701
Reviewed-by: Stephen Adams <[email protected]>
Commit-Queue: Nicholas Shahan <[email protected]>
copybara-service bot pushed a commit that referenced this issue May 27, 2022
@nshahan
[ddc] Migrate shared_compiler to null safety
9510eb9 
Issue: #46617
Change-Id: I9798ccaf61360c9dd6baab2e07c5d228eb45cdc4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/245461
Reviewed-by: Mark Zhou <[email protected]>
copybara-service bot pushed a commit that referenced this issue May 27, 2022
@nshahan
[ddc] Migrate js_metalet to null safety
e948516 
Issue: #46617
Change-Id: If3e62c17e9d7f6ae033cce8efd7c71caf611c7f7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/245283
Reviewed-by: Anna Gringauze <[email protected]>
copybara-service bot pushed a commit that referenced this issue May 27, 2022
@nshahan
[ddc] Migrate module_builder to null safety
fe91c01 
Issue: #46617
Change-Id: I977cf87a4461863b39ee52beb5404cb80f1ac3c6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/245284
Commit-Queue: Nicholas Shahan <[email protected]>
Reviewed-by: Anna Gringauze <[email protected]>
copybara-service bot pushed a commit that referenced this issue May 27, 2022
@nshahan
[ddc] Migrate property_model to null safety
dcc9787 
Issue: #46617
Change-Id: Ie1e557c698452bee7e16b959078db941863d4d99
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/246162
Reviewed-by: Mark Zhou <[email protected]>
Commit-Queue: Nicholas Shahan <[email protected]>
@jakemac53 jakemac53 mentioned this issue Jun 8, 2022
Closed
copybara-service bot pushed a commit that referenced this issue Jun 21, 2022
@nshahan
[ddc] Migrate shared_command to null safety
c53c689 
Update CFE API for ddc to mirror the nullability of fields in
`CompilerOptions`.

Issue: #46617
Change-Id: I08d8cc2c5bb1dba4823cb3a7e1f4a540fb3bfef5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/248181
Commit-Queue: Nicholas Shahan <[email protected]>
Reviewed-by: Mark Zhou <[email protected]>
Reviewed-by: Johnni Winther <[email protected]>
copybara-service bot pushed a commit that referenced this issue Jun 22, 2022
@nshahan
[ddc] Migrate nullable_inference to null safety
c52dd25 
Also migrate the test file and temporarily inline some path
generation logic to break import of command.dart until it is
migrated.

Issue: #46617
Change-Id: I50c158729346f3e31059241b90008ba861a65422
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/248341
Reviewed-by: Anna Gringauze <[email protected]>
copybara-service bot pushed a commit that referenced this issue Jun 22, 2022
@nshahan
[ddc] Migrate compiler to null safety
de90931 
Issue: #46617
Change-Id: Id6a5e2e435b22fad4afcb5d06d0a50dc617f4bf3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/248705
Reviewed-by: Anna Gringauze <[email protected]>
copybara-service bot pushed a commit that referenced this issue Jun 22, 2022
@nshahan
[ddc] Migrate expression_compiler to null safety
6366fdd 
Migrate the test file that is unblocked.

Issue: #46617
Change-Id: I65598f5837115d7dce1c51389bb7c762c1ce451e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/248884
Reviewed-by: Anna Gringauze <[email protected]>
copybara-service bot pushed a commit that referenced this issue Jun 22, 2022
@nshahan
[ddc] Migrate command to null safety
3f104a2 
Revert small diffs introduced in earlier migrations to avoid an
import of command.dart before it was migrated.

Issue: #46617
Change-Id: Ia728fd727417fd4fdf8c454a0044e096e9de5756
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/248948
Reviewed-by: Anna Gringauze <[email protected]>
Commit-Queue: Nicholas Shahan <[email protected]>
copybara-service bot pushed a commit that referenced this issue Jun 22, 2022
@nshahan
[ddc] Migrate tests to null safety
9b9bfc3 
Migrate the tests for expression_compiler.

Issue: #46617
Change-Id: I075787dff4ad33d13115b66170bf89260a52015f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/248949
Reviewed-by: Mark Zhou <[email protected]>
copybara-service bot pushed a commit that referenced this issue Jun 22, 2022
@nshahan
[ddc] Migrate sourcemap and stacktrace tests
4c5a046 
- Migrate suites and test files to null safety.
- Fix previous migration of sourcemap_testing to ensure list of
  expected stops could include null values.

Issue: #46617
Change-Id: Idd3b0937942cef18ae66d35137230437e1e971a0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/249063
Reviewed-by: Mark Zhou <[email protected]>
copybara-service bot pushed a commit that referenced this issue Jun 22, 2022
@nshahan
[ddc] Migrate more tests to null safety
f1d2813 
Issue: #46617
Change-Id: I7f27810c0ca825ea777e6c6bfcade6a8ee2b06e8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/249065
Reviewed-by: Mark Zhou <[email protected]>
Commit-Queue: Nicholas Shahan <[email protected]>
@devoncarew devoncarew mentioned this issue Jun 23, 2022
Closed
26 tasks
copybara-service bot pushed a commit that referenced this issue Jul 1, 2022
@nshahan
[ddc] Fix cast when retrieving annotation name
f3daca2 
Name can be null and cast failures start appearing here when
running with sound null safety.

Issue: #46617
Change-Id: I3d96e80283889915cc28a310a1db940a9c6bcab1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/250409
Reviewed-by: Mark Zhou <[email protected]>
Commit-Queue: Nicholas Shahan <[email protected]>
copybara-service bot pushed a commit that referenced this issue Jul 18, 2022
@nshahan
[ddc] Migrate expression_compiler_worker
38dc4ed 
Migrate library and tests to null safety.

Issue: #46617
Change-Id: I6657ebdeda7c9b4650cc6286229d2f4babdca5be
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/250260
Commit-Queue: Nicholas Shahan <[email protected]>
Reviewed-by: Anna Gringauze <[email protected]>
copybara-service bot pushed a commit that referenced this issue Jul 18, 2022
@nshahan
[ddc] Migrate module symbol tests to null safety
d795274 
Issue: #46617
Change-Id: I168a02faeb2288430f4daa998a294ab6bd970031
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/250321
Commit-Queue: Nicholas Shahan <[email protected]>
Reviewed-by: Anna Gringauze <[email protected]>
copybara-service bot pushed a commit that referenced this issue Jul 18, 2022
@nshahan
[ddc] Migrate last tests to null safety
2f39f86 
Issue: #46617
Change-Id: I972864df3d5f036a19d3731052e4d5369c399ae7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/250340
Commit-Queue: Nicholas Shahan <[email protected]>
Reviewed-by: Mark Zhou <[email protected]>
copybara-service bot pushed a commit that referenced this issue Jul 19, 2022
@nshahan
[ddc] Migrate ddc library to null safety
5cc2856 
Issue: #46617
Change-Id: I15468560685b1107ec5481f2bda5a0fcb2a6bb7c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/250341
Reviewed-by: Mark Zhou <[email protected]>
Commit-Queue: Nicholas Shahan <[email protected]>
copybara-service bot pushed a commit that referenced this issue Jul 19, 2022
@nshahan
[ddc] Migrate dev_compiler library to null safety
768d6ca 
Issue: #46617
Change-Id: I87d8bcb65e22f4d25cc24694ababa1a16d42bdd7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/250348
Reviewed-by: Mark Zhou <[email protected]>
Commit-Queue: Nicholas Shahan <[email protected]>
copybara-service bot pushed a commit that referenced this issue Jul 19, 2022
@nshahan
[ddc] Migrate dartdevc entrypoint to null safety
ca8b500 
Issue: #46617
Change-Id: I6ba216ba41a6c115f9c46908378d21bee0940bdc
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/250349
Commit-Queue: Nicholas Shahan <[email protected]>
Reviewed-by: Mark Zhou <[email protected]>
copybara-service bot pushed a commit that referenced this issue Jul 19, 2022
@nshahan
[ddc] Migrate compile sdk script to null safety
a710f97 
Issue: #46617
Change-Id: I48dcf20dc3cada2bd9d0c9dfb0e1f27f07d5e521
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/250350
Reviewed-by: Sigmund Cherem <[email protected]>
Commit-Queue: Nicholas Shahan <[email protected]>
copybara-service bot pushed a commit that referenced this issue Jul 19, 2022
@nshahan
[ddc] Migrate stack trace utilities to null safety
017401c 
Issue: #46617
Change-Id: Idfd614e3bcc4e3e8ae1597d69c97d007b7efd306
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/250351
Commit-Queue: Nicholas Shahan <[email protected]>
Reviewed-by: Sigmund Cherem <[email protected]>
copybara-service bot pushed a commit that referenced this issue Jul 19, 2022
@nshahan
[ddc] Migrate ddb script to null safety
a6478ba 
Issue: #46617
Change-Id: I34e9c11f6c721ca460a39f0037bf841afb6725f5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/250352
Reviewed-by: Sigmund Cherem <[email protected]>
Commit-Queue: Nicholas Shahan <[email protected]>
@nshahan
Copy link
Contributor Author

nshahan commented Jul 29, 2022

The migration is now complete!

@nshahan nshahan closed this as completed Jul 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nshahan nshahan

Labels
area-web-js Issues related to JavaScript support for Dart Web, including DDC, dart2js, and JS interop. P3 A lower priority bug or feature request web-dev-compiler web-triage-1 priority assigned
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@nshahan