Skip to content

Failures on Reland "[vm] Fix some async* semantics issues: Only run generator if there's active subscription (not paused/cancelled)" #48907

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
brianquinlan opened this issue Apr 27, 2022 · 3 comments
Closed

Failures on Reland "[vm] Fix some async* semantics issues: Only run generator if there's active subscription (not paused/cancelled)" #48907

brianquinlan opened this issue Apr 27, 2022 · 3 comments
Assignees
@mkustermann
Labels
area-web-js Issues related to JavaScript support for Dart Web, including DDC, dart2js, and JS interop. web-dart2js

Comments

@brianquinlan
Copy link
Contributor

There are new test failures on Reland "[vm] Fix some async* semantics issues: Only run generator if there's active subscription (not paused/cancelled)".

The tests

language/async_star/throw_in_catch_test RuntimeError (expected Pass)
language_2/async_star/throw_in_catch_test RuntimeError (expected Pass)
vm/dart_2/causal_stacks/flutter_regress_100441_test RuntimeError (expected Pass)

are failing on configurations

dart2js-canary-linux-d8
dart2js-hostasserts-linux-ia32-d8
dart2js-hostasserts-strong-linux-x64-d8
dart2js-hostasserts-weak-linux-x64-d8
dart2js-linux-chrome
dart2js-linux-firefox
dart2js-mac-chrome
dart2js-minified-csp-linux-chrome
dart2js-minified-linux-d8
dart2js-production-linux-d8
dart2js-win-chrome
dartkp-dwarf-linux-product-x64
dartkp-obfuscate-linux-release-x64
@lrhn
Copy link
Member

lrhn commented Apr 28, 2022

Very likely, the tests are now correct, and dart2js is failing them.

@lrhn lrhn added web-dart2js area-web-js Issues related to JavaScript support for Dart Web, including DDC, dart2js, and JS interop. labels Apr 28, 2022
@mkustermann
Copy link
Member

Agree with @lrhn, I think this is mainly a dup of #48749 (it got reverted + relanded which is probably why it showed up as unapproved failures again).

@sigmundch
Copy link
Member

Thanks! I'll close this and use #48749 to track.

copybara-service bot pushed a commit that referenced this issue Apr 29, 2022
@mkustermann
[gardening] Mark stacktrace-asserting tests as SkipByDesign in obfusc…
a9c1cb6 
…ated/non-symbolic-dwarf mode

Issue #48907

TEST=Updates status file.

Change-Id: I4a80611fdd91eb44f082d429553ecc778fb407cf
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/242866
Reviewed-by: Daco Harkes <[email protected]>
Commit-Queue: Martin Kustermann <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mkustermann mkustermann

Labels
area-web-js Issues related to JavaScript support for Dart Web, including DDC, dart2js, and JS interop. web-dart2js
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@sigmundch @lrhn @mkustermann @brianquinlan