Skip to content

Improve getInstancesAsList #51497

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
derekxu16 opened this issue Feb 22, 2023 · 0 comments
Open

Improve getInstancesAsList #51497

derekxu16 opened this issue Feb 22, 2023 · 0 comments
Assignees
@derekxu16
Labels
area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. P3 A lower priority bug or feature request triaged Issue has been triaged by sub team type-enhancement A request for a change that isn't a bug vm-service The VM Service Protocol, both the specification and its implementation

Comments

@derekxu16
Copy link
Member

See https://dart-review.googlesource.com/c/sdk/+/283380/comment/b86443cf_5d0f91bf/
@derekxu16 derekxu16 added area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. P2 A bug or feature request we're likely to work on triaged Issue has been triaged by sub team vm-service The VM Service Protocol, both the specification and its implementation labels Feb 22, 2023
@derekxu16 derekxu16 self-assigned this Feb 23, 2023
copybara-service bot pushed a commit that referenced this issue Feb 23, 2023
@derekxu16
[VM/Service] Improve documentation of getInstancesAsList
d128fea 
This CL addresses some of the feedback in https://dart-review.googlesource.com/c/sdk/+/283380/comment/b86443cf_5d0f91bf/

TEST=CI

Issue: #51497
Change-Id: I26622287df8834bbacbe3fdfb95490350cecd4bb
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/284724
Reviewed-by: Ben Konyi <[email protected]>
Commit-Queue: Derek Xu <[email protected]>
@derekxu16 derekxu16 added the type-enhancement A request for a change that isn't a bug label Apr 27, 2023
@a-siva a-siva added P3 A lower priority bug or feature request and removed P2 A bug or feature request we're likely to work on labels Aug 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@derekxu16 derekxu16

Labels
area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. P3 A lower priority bug or feature request triaged Issue has been triaged by sub team type-enhancement A request for a change that isn't a bug vm-service The VM Service Protocol, both the specification and its implementation
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@derekxu16 @a-siva