Skip to content

Lock down the no-sound-null-safety option in the compiler #51513

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
a-siva opened this issue Feb 23, 2023 · 3 comments
Closed

Lock down the no-sound-null-safety option in the compiler #51513

a-siva opened this issue Feb 23, 2023 · 3 comments
Assignees
@bkonyi
Labels
area-dart-cli Use area-dart-cli for issues related to the 'dart' command like tool. P2 A bug or feature request we're likely to work on
Milestone
Dart 3 beta 2

Comments

@a-siva
Copy link
Contributor

a-siva commented Feb 23, 2023

The option of completely dropping support for unsound null safety in the Dart SDK as a build time option was explored in #50348, looks like this option needs to wait until all Flutter code internally is migrated to be null safe.

As an alternative we will lock down the option to pass --no-sound-null-safety option in the compile command (both kernel and aot) and the run command will run in unsound mode when the input file is a kernel file or AOT snapshot compiled using the unsound option.
@a-siva a-siva added the area-dart-cli Use area-dart-cli for issues related to the 'dart' command like tool. label Feb 23, 2023
@a-siva a-siva added this to the Dart 3 beta 2 milestone Feb 23, 2023
@a-siva
Copy link
Contributor Author

a-siva commented Feb 23, 2023

Here is a CL that does some of this https://dart-review.googlesource.com/c/sdk/+/284900

@a-siva a-siva added the P2 A bug or feature request we're likely to work on label Feb 24, 2023
copybara-service bot pushed a commit that referenced this issue Feb 24, 2023
@bkonyi
[ CLI ] Lockdown --no-sound-null-safety in dart compile subcommands
a569f4a 
Related to #51513

Change-Id: Ie798af562133b933a76351b9e7244870ea49e6dd
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/285380
Commit-Queue: Ben Konyi <[email protected]>
Reviewed-by: Siva Annamalai <[email protected]>
@vsmenon
Copy link
Member

vsmenon commented Feb 27, 2023

@bkonyi - I think you're point on this? Please let me know if not. :-)

@bkonyi
Copy link
Contributor

bkonyi commented Feb 27, 2023

@bkonyi - I think you're point on this? Please let me know if not. :-)

I am, and this should be resolved by a569f4a :-)

@bkonyi bkonyi closed this as completed Feb 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bkonyi bkonyi

Labels
area-dart-cli Use area-dart-cli for issues related to the 'dart' command like tool. P2 A bug or feature request we're likely to work on
Projects
None yet
Milestone
Dart 3 beta 2
Development

No branches or pull requests
3 participants
@vsmenon @a-siva @bkonyi