Skip to content

GeneralizingAstVisitor.visitNamedType does not call visitTypeAnnotation #55011

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
rrousselGit opened this issue Feb 24, 2024 · 2 comments
Closed

GeneralizingAstVisitor.visitNamedType does not call visitTypeAnnotation #55011

rrousselGit opened this issue Feb 24, 2024 · 2 comments
Assignees
@scheglov
Labels
analyzer-api Issues that impact the public API of the analyzer package legacy-area-analyzer Use area-devexp instead. P2 A bug or feature request we're likely to work on

Comments

@rrousselGit
Copy link

Hello!

Currently the implementation of GeneralizingAstVisitor.visitNamedType is:

@override
R? visitNamedType(NamedType node) => visitNode(node);

The thing is, NamedType is a subclass of TypeAnnotation. It would likely be more correct to have:

@override
R? visitNamedType(NamedType node) => visitTypeAnnotation(node);
@lrhn lrhn added the legacy-area-analyzer Use area-devexp instead. label Feb 25, 2024
@srawlins
Copy link
Member

CC @scheglov

@srawlins srawlins added P2 A bug or feature request we're likely to work on analyzer-api Issues that impact the public API of the analyzer package labels Feb 26, 2024
@scheglov scheglov self-assigned this Feb 26, 2024
@scheglov
Copy link
Contributor

https://dart-review.googlesource.com/c/sdk/+/354440

copybara-service bot pushed a commit that referenced this issue Feb 26, 2024
@scheglov
Issue 55011. Fix GeneralizingAstVisitor.visitNamedType() to invoke vi…
1818a2f 
…sitTypeAnnotation().

Bug: #55011
Change-Id: I1bcd12afdc8cf9645aaca6b11baf9b738750414b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/354440
Reviewed-by: Brian Wilkerson <[email protected]>
Commit-Queue: Konstantin Shcheglov <[email protected]>
Reviewed-by: Samuel Rawlins <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@scheglov scheglov

Labels
analyzer-api Issues that impact the public API of the analyzer package legacy-area-analyzer Use area-devexp instead. P2 A bug or feature request we're likely to work on
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@srawlins @scheglov @lrhn @rrousselGit