Skip to content

☂ downstream package updates to prepare for 1.4.0 (and improved directives_ordering) #58380

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
9 tasks done
pq opened this issue Apr 25, 2021 · 8 comments
Closed
9 tasks done

☂ downstream package updates to prepare for 1.4.0 (and improved directives_ordering) #58380

pq opened this issue Apr 25, 2021 · 8 comments
Assignees
@pq
Labels
area-meta Cross-cutting, high-level issues (for tracking many other implementation issues, ...). customer-google3 devexp-linter Issues with the analyzer's support for the linter package legacy-area-analyzer Use area-devexp instead.

Comments

@pq
Copy link
Member

pq commented Apr 25, 2021 •
edited
Loading

Linter 1.4.0 introduces directives_ordering updated to sort more cases (see dart-archive/linter#2596). In order to land in the Dart SDK (cl/196581), a number of downstream fixes need to be made to SDK and Flutter packages.

Dart SDK:

Flutter:

...

(Some downstream packages):
@pq pq added customer-google3 area-meta Cross-cutting, high-level issues (for tracking many other implementation issues, ...). labels Apr 25, 2021
@pq pq self-assigned this Apr 25, 2021
This was referenced Apr 26, 2021
Merged
Merged
Merged
@kevmoo
Copy link
Member

kevmoo commented Apr 26, 2021

I like the change, it just requires some follow-up on the package side.

@pq
Copy link
Member Author

pq commented Apr 26, 2021

UPDATE: I've got yet one more change queued up to fix flutter (flutter/flutter#81210) but even then it's a race and there's a chance that violations will get introduced before the auto-roll.

@goderbauer: do you object to me disabling the lint until the next roll when I can re-enable it and fix up any newly introduced breakages?

@pq
Copy link
Member Author

pq commented Apr 26, 2021

@kevmoo: 💯

To be honest, I wasn't expecting this broad impact. (Nor do I expect was @davidmorgan 😄.) Thinking ahead, it'd be great to have some way to get proactive about tracking soon to be breaking ecosystem packages so we can (ideally) fix them up proactively. @athomas and I were chatting about this a bit... Maybe we could leverage the index you have in repo_manager?

@pq
Copy link
Member Author

pq commented Apr 26, 2021

FWIW, here's another breakage, unrelated to this change, that would have been nice to detect (and fix) proactively:

dart-archive/graphs#63

(fyi @bwilkerson @scheglov)

@goderbauer
Copy link
Contributor

@goderbauer: do you object to me disabling the lint until the next roll when I can re-enable it and fix up any newly introduced breakages?

No objections. (I suspect there will still be a race between your change enabling it again and other changes, but maybe that race is easier to manage?)

@pq
Copy link
Member Author

pq commented Apr 26, 2021

Right. It also has the advantage of something I can do and manage manually (as opposed to an auto-roll that just gets blocked).

This was referenced Apr 26, 2021
Closed
Merged
Merged
Merged
Merged
dart-bot referenced this issue Apr 27, 2021
@pq
Reland "linter 1.4.0"
513c1a1 
This is a reland of 17644ee

Additional supporting changes in flutter (and plugins):

flutter/flutter#81017
flutter/plugins#3823
flutter/flutter#80817
flutter/flutter#80901
flutter/flutter#81210

Additional context in meta linter issue: https://github.com/dart-lang/linter/issues/2609





Original change's description:
> linter 1.4.0
>
> Mitigating PRs:
>
> https://dart-review.googlesource.com/c/sdk/+/196223
> https://dart-review.googlesource.com/c/sdk/+/196180
>
> flutter/flutter#80817
> flutter/flutter#80901
>
>
>
>
>
> Change-Id: Ib916d541076e24b9e8db1d6120dbc043d9e40b87
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/196026
> Commit-Queue: Phil Quitslund <[email protected]>
> Reviewed-by: Brian Wilkerson <[email protected]>

Change-Id: Ie6b9682a2f54ef039dd7ac9c6a46cb925615acef
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/196581
Commit-Queue: Phil Quitslund <[email protected]>
Reviewed-by: Brian Wilkerson <[email protected]>
@pq
Copy link
Member Author

pq commented Apr 27, 2021

Linter 1.4.0 is re-landed in the SDK as of 513c1a1. When it gets rolled into Flutter, I'll loop back and re-enable the lint in the Flutter options.

jason-simmons referenced this issue in jason-simmons/flutter Apr 29, 2021
@jason-simmons
Ignore the sort order of imports in generated_plugin_registrant.dart
2eaca9a 
See https://github.com/dart-lang/linter/issues/2609
@jason-simmons jason-simmons mentioned this issue Apr 29, 2021
Merged
jason-simmons referenced this issue in jason-simmons/flutter_cocoon Apr 29, 2021
@jason-simmons
Update imports to match the latest directives_ordering analyzer check
d52b2de 
See https://github.com/dart-lang/linter/issues/2609
@jason-simmons jason-simmons mentioned this issue Apr 29, 2021
Merged
jason-simmons referenced this issue in jason-simmons/flutter_gallery Apr 29, 2021
@jason-simmons
Update imports to match the latest directives_ordering analyzer check
4a2ef4e 
See https://github.com/dart-lang/linter/issues/2609
@jason-simmons jason-simmons mentioned this issue Apr 29, 2021
Merged
jason-simmons referenced this issue in jason-simmons/flutter_packages Apr 29, 2021
@jason-simmons
Update imports to match the latest directives_ordering analyzer check
3f74f29 
See https://github.com/dart-lang/linter/issues/2609
@jason-simmons jason-simmons mentioned this issue Apr 29, 2021
Merged
jason-simmons referenced this issue in jason-simmons/flutter_gallery Apr 29, 2021
@jason-simmons
Update imports to match the latest directives_ordering analyzer check
547f950 
See https://github.com/dart-lang/linter/issues/2609
guidezpl referenced this issue in flutter/gallery Apr 29, 2021
@jason-simmons
Update imports to match the latest directives_ordering analyzer check (…
a9b8d6c 
…#494)

See https://github.com/dart-lang/linter/issues/2609
zanderso referenced this issue in flutter/packages Apr 29, 2021
@jason-simmons
Update imports to match the latest directives_ordering analyzer check (…
eff3dba 
…#333)

See https://github.com/dart-lang/linter/issues/2609
godofredoc referenced this issue in flutter/cocoon Apr 29, 2021
@jason-simmons @zanderso
Update imports to match the latest directives_ordering analyzer check (…
d021f7e 
…#1183)

* Update imports to match the latest directives_ordering analyzer check

See https://github.com/dart-lang/linter/issues/2609

* Update README.md to describe new import sorting rules.

Co-authored-by: Zachary Anderson <[email protected]>
@zanderso zanderso mentioned this issue Apr 29, 2021
Merged
@pq
Copy link
Member Author

pq commented May 1, 2021

Closed w/ flutter/flutter#81219. Downstream changes may continue to trickle in.

@pq pq closed this as completed May 1, 2021
@pq pq mentioned this issue Jun 2, 2021
Merged
@pq pq mentioned this issue Jul 6, 2021
Closed
@pq pq mentioned this issue Oct 7, 2021
Closed
4 tasks
Seven-112 referenced this issue in Seven-112/gallery May 16, 2023
Update imports to match the latest directives_ordering analyzer check…
e43bb0e 
… (#494)

See https://github.com/dart-lang/linter/issues/2609
@devoncarew devoncarew added devexp-linter Issues with the analyzer's support for the linter package legacy-area-analyzer Use area-devexp instead. labels Nov 19, 2024
@devoncarew devoncarew transferred this issue from dart-archive/linter Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pq pq

Labels
area-meta Cross-cutting, high-level issues (for tracking many other implementation issues, ...). customer-google3 devexp-linter Issues with the analyzer's support for the linter package legacy-area-analyzer Use area-devexp instead.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@kevmoo @pq @goderbauer @devoncarew