This repository was archived by the owner on Nov 20, 2024. It is now read-only.
Fix directives_ordering for non-pub packages.
#2596
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bwilkerson
approved these changes
Apr 16, 2021
| @@ -271,7 +271,14 @@ class _Visitor extends SimpleAstVisitor<void> { | |||
| _checkSectionInOrder(lintedNodes, relativeExports); | |||
|
|
|||
| var projectName = project?.name; | |||
| if (projectName != null) { | |||
| if (projectName == null) { | |||
| // Not a pub package. Package directives should be sorted in one block. | |||
There was a problem hiding this comment.
It would be good to have some tests for this case, but I don't know whether our current test framework supports test cases in non-pub packages.
There was a problem hiding this comment.
Thanks.
I hadn't noticed the test for this rule under integration; now I did notice it and tried to add coverage--but didn't figure out a way to trigger this codepath.
pq
approved these changes
Apr 16, 2021
davidmorgan
force-pushed
the
directives-ordering-fix
branch
from
d7a0bc8 to
8bb4d82
Compare
|
Please let me know re: test coverage. Also, please merge if you want to, I don't have merge privileges here :) |
|
We can loop back about improved test coverage. I'll land for now. Thanks! |
9 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
directives_orderinghad a gap for google3 because those don't count as pub packages; this seems to do the job.