Invalid vm isolate snapshot seen when running webdev e2e_test.dart on Windows
#59784
Comments
bkonyi
added
area-vm
This reverts commit c5c3544. Reason for revert: #59784 Original change's description: > Fix Fuchsia build error. > > TEST=ci > > Change-Id: I31c160770bea6ba03fe3ca76545c37ffec94e44e > Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/401483 > Commit-Queue: Siva Annamalai <[email protected]> > Reviewed-by: Brian Quinlan <[email protected]> Change-Id: I302d407a5063a1989d05605e01da71913a8742e7 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/401902 Reviewed-by: Sigmund Cherem <[email protected]> Bot-Commit: Rubber Stamper <[email protected]> Commit-Queue: Ben Konyi <[email protected]>
This reverts commit 08252fc. Reason for revert: #59784 Original change's description: > [dartdev] Use VmInteropHandler for invoking sub commands > > Use VmInteropHandler for invoking sub commands instead of running them > in an isolate. Running sub commands in an isolate causes an increased footprint. > Changing this to use VmInteropHandler avoids the additional memory footprint. > > Commands that need to use an AOT runtime for execution now exec the AOT > runtime and run the command. > > TEST=ci > > Change-Id: If7aed1cab2fec9d9940bd562ad5aa9c4e9a6ac7f > Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/398604 > Reviewed-by: Ben Konyi <[email protected]> > Reviewed-by: Brian Quinlan <[email protected]> > Commit-Queue: Siva Annamalai <[email protected]> Change-Id: I82a997d49a7d52e1fdaa7d75f509603ebe5e51dd Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/401901 Reviewed-by: Siva Annamalai <[email protected]> Reviewed-by: Sigmund Cherem <[email protected]> Bot-Commit: Rubber Stamper <[email protected]>
|
A change was added to provide a proper message here https://dart-review.googlesource.com/c/sdk/+/402202 It is highly likely we have a path in this test which is loading an AOT snapshot of dart2js into a VM that is running in JIT mode |
webdev/test/e2e_test.dart was failing due to paths with spaces not being handled correctly. Related issue: #2556 Fixes dart-lang/sdk#59784
|
I'm not sure if this is the same issue or I should raise in flutter/flutter, but I see this same error when trying to use Removing the space from the Flutter SDK changes the error to this: This one is because of the space in the test project. Removing that spaces resolves the issue I can build. I deliberately have spaces in both paths because other users sometimes do - for example if their Windows username is "Firstname Lastname" and the put things in |
|
Do you still see the above error even after 08252fc was reverted |
|
@a-siva if that question was for me I was using |
|
Oh, but the commit you linked was the original and not the revert. When was the revert made? (I had a search but couldn't see it) Edit: Revert is https://dart-review.googlesource.com/c/sdk/+/401901, which was also Dec 20th, so I believe should be in Flutter master. |
|
In that case, I believe I have both of them: (although it's not clear to me what the interaction is between spaces in the paths and those changes) |
|
The last roll of Dart into Flutter was Version 3.7.0-267.0.dev, so I believe the reverts are not in Flutter main yet. |
|
Oops, you're right - I only checked the dates and assumed. I will re-test that once it's rolled in then. |
webdev/test/e2e_test.dart was failing due to paths with spaces not being handled correctly. Related issue: #2556 Fixes dart-lang/sdk#59784
|
From dart-lang/webdev#2556: After some digging, it turns out that the webdev tests can make a copy of the SDK under the temp directory for use in tests. This directory name was prefixed with sdk copy. Logging landed by @a-siva indicated that webdev/test/e2e_test.dart was failing with the following message:
Changing the copied SDK directory name prefix to sdk_copy resolved the issue, implying that paths with spaces aren't being escaped properly when we call exec into the |
|
https://dart-review.googlesource.com/c/sdk/+/402781 accounts for the possibility of spaces in path names. |
After 08252fc we've started seeing the
Invalid vm isolate snapshot seenfor webdev'se2e_test.darton Windows. Based on a quick look, the VM isolate apparently is missing its magic number.The text was updated successfully, but these errors were encountered: