-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Dart analysis issue with Android Studio (Flutter 3.27.3, Dart 3.6.1) #60683
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
The issue has nothing to do with the changes to Skia, it's a result of an incomplete implementation in the analyzer. This needs to be implemented on the analyzer side. Unfortunately, the exception message doesn't indicate what class of element doesn't have the required implementation of We should fix this before the 3.9 / 3.33 release. And probably before publishing another version of the Also, on the server side, we should guard the execution of |
It looks that in |
Should we remove the throw and make the method (in |
It is still the same in Yes, making |
I'm not sure what that means. The getter is being invoked here (https://github.com/dart-lang/sdk/blob/main/pkg/analysis_server/lib/src/services/correction/dart/import_add_show.dart#L71) as a result of asking an Maybe the bug is that we're associating the wrong write element with the node? |
I don't mean that the API is not used, only that the fact that we give Anyway, we will not do any significant change right now. |
…ement2, when GenericFunctionTypeElementImpl2. Bug: #60683 Change-Id: I122eed163c8f713ca1dd416c194eb432f23802de Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/427300 Reviewed-by: Brian Wilkerson <[email protected]> Commit-Queue: Konstantin Shcheglov <[email protected]>
CL for back-porting as |
Just to be sure this wasn't forgotten. Has this been done too @bwilkerson? |
Not that I'm aware of, no. |
I'm having an issue inside Android Studio, not sure if this related to dart analyzer or not, but in Android Studio when I switch between .dart files and have Dart analyzer enabled, Android Studio always throws this error:
Dart Analysis Issue
UnimplementedError
The error shows this
`
Dart analysis issue
UnimplementedError
Version information
Details
UnimplementedError
#0 ElementImpl2.enclosingElement2 (package:analyzer/src/dart/element/element.dart:3106:38)
#1 _ReferenceFinder.visitAssignmentExpression (package:analysis_server/src/services/correction/dart/import_add_show.dart:71:51)
#2 AssignmentExpressionImpl.accept (package:analyzer/src/dart/ast/ast.dart:954:15)
#3 ExpressionStatementImpl.visitChildren (package:analyzer/src/dart/ast/ast.dart:6366:17)
#4 RecursiveAstVisitor.visitExpressionStatement (package:analyzer/dart/ast/visitor.dart:1099:10)
#5 ExpressionStatementImpl.accept (package:analyzer/src/dart/ast/ast.dart:6362:50)
#6 NodeListImpl.accept (package:analyzer/src/dart/ast/ast.dart:13009:20)
#7 SwitchPatternCaseImpl.visitChildren (package:analyzer/src/dart/ast/ast.dart:17380:16)
#8 RecursiveAstVisitor.visitSwitchPatternCase (package:analyzer/dart/ast/visitor.dart:1740:10)
#9 SwitchPatternCaseImpl.accept (package:analyzer/src/dart/ast/ast.dart:17374:50)
#10 NodeListImpl.accept (package:analyzer/src/dart/ast/ast.dart:13009:20)
#11 SwitchStatementImpl.visitChildren (package:analyzer/src/dart/ast/ast.dart:17497:14)
#12 RecursiveAstVisitor.visitSwitchStatement (package:analyzer/dart/ast/visitor.dart:1746:10)
#13 SwitchStatementImpl.accept (package:analyzer/src/dart/ast/ast.dart:17492:50)
#14 NodeListImpl.accept (package:analyzer/src/dart/ast/ast.dart:13009:20)
#15 BlockImpl.visitChildren (package:analyzer/src/dart/ast/ast.dart:2051:17)
#16 RecursiveAstVisitor.visitBlock (package:analyzer/dart/ast/visitor.dart:883:10)
#17 BlockImpl.accept (package:analyzer/src/dart/ast/ast.dart:2047:50)
#18 IfStatementImpl.visitChildren (package:analyzer/src/dart/ast/ast.dart:9730:20)
#19 RecursiveAstVisitor.visitIfStatement (package:analyzer/dart/ast/visitor.dart:1273:10)
#20 IfStatementImpl.accept (package:analyzer/src/dart/ast/ast.dart:9724:50)
#21 NodeListImpl.accept (package:analyzer/src/dart/ast/ast.dart:13009:20)
#22 BlockImpl.visitChildren (package:analyzer/src/dart/ast/ast.dart:2051:17)
#23 RecursiveAstVisitor.visitBlock (package:analyzer/dart/ast/visitor.dart:883:10)
#24 BlockImpl.accept (package:analyzer/src/dart/ast/ast.dart:2047:50)
#25 BlockFunctionBodyImpl.visitChildren (package:analyzer/src/dart/ast/ast.dart:2007:12)
#26 RecursiveAstVisitor.visitBlockFunctionBody (package:analyzer/dart/ast/visitor.dart:889:10)
#27 BlockFunctionBodyImpl.accept (package:analyzer/src/dart/ast/ast.dart:1999:50)
#28 FunctionExpressionImpl.visitChildren (package:analyzer/src/dart/ast/ast.dart:8624:11)
#29 RecursiveAstVisitor.visitFunctionExpression (package:analyzer/dart/ast/visitor.dart:1213:10)
#30 FunctionExpressionImpl.accept (package:analyzer/src/dart/ast/ast.dart:8613:50)
#31 NodeListImpl.accept (package:analyzer/src/dart/ast/ast.dart:13009:20)
#32 ArgumentListImpl.visitChildren (package:analyzer/src/dart/ast/ast.dart:476:16)
#33 RecursiveAstVisitor.visitArgumentList (package:analyzer/dart/ast/visitor.dart:823:10)
#34 ArgumentListImpl.accept (package:analyzer/src/dart/ast/ast.dart:472:50)
#35 MethodInvocationImpl.visitChildren (package:analyzer/src/dart/ast/ast.dart:12258:19)
#36 RecursiveAstVisitor.visitMethodInvocation (package:analyzer/dart/ast/visitor.dart:1411:10)
#37 _ReferenceFinder.visitMethodInvocation (package:analysis_server/src/services/correction/dart/import_add_show.dart:96:11)
#38 MethodInvocationImpl.accept (package:analyzer/src/dart/ast/ast.dart:12246:50)
#39 ExpressionStatementImpl.visitChildren (package:analyzer/src/dart/ast/ast.dart:6366:17)
#40 RecursiveAstVisitor.visitExpressionStatement (package:analyzer/dart/ast/visitor.dart:1099:10)
#41 ExpressionStatementImpl.accept (package:analyzer/src/dart/ast/ast.dart:6362:50)
#42 NodeListImpl.accept (package:analyzer/src/dart/ast/ast.dart:13009:20)
#43 BlockImpl.visitChildren (package:analyzer/src/dart/ast/ast.dart:2051:17)
#44 RecursiveAstVisitor.visitBlock (package:analyzer/dart/ast/visitor.dart:883:10)
#45 BlockImpl.accept (package:analyzer/src/dart/ast/ast.dart:2047:50)
#46 BlockFunctionBodyImpl.visitChildren (package:analyzer/src/dart/ast/ast.dart:2007:12)
#47 RecursiveAstVisitor.visitBlockFunctionBody (package:analyzer/dart/ast/visitor.dart:889:10)
#48 BlockFunctionBodyImpl.accept (package:analyzer/src/dart/ast/ast.dart:1999:50)
#49 MethodDeclarationImpl.visitChildren (package:analyzer/src/dart/ast/ast.dart:12069:10)
#50 RecursiveAstVisitor.visitMethodDeclaration (package:analyzer/dart/ast/visitor.dart:1405:10)
#51 MethodDeclarationImpl.accept (package:analyzer/src/dart/ast/ast.dart:12061:50)
#52 NodeListImpl.accept (package:analyzer/src/dart/ast/ast.dart:13009:20)
#53 ClassDeclarationImpl.visitChildren (package:analyzer/src/dart/ast/ast.dart:2939:13)
#54 RecursiveAstVisitor.visitClassDeclaration (package:analyzer/dart/ast/visitor.dart:937:10)
#55 ClassDeclarationImpl.accept (package:analyzer/src/dart/ast/ast.dart:2929:50)
#56 NodeListImpl.accept (package:analyzer/src/dart/ast/ast.dart:13009:20)
#57 CompilationUnitImpl.visitChildren (package:analyzer/src/dart/ast/ast.dart:3621:21)
#58 RecursiveAstVisitor.visitCompilationUnit (package:analyzer/dart/ast/visitor.dart:961:10)
#59 CompilationUnitImpl.accept (package:analyzer/src/dart/ast/ast.dart:3614:50)
#60 ImportAddShow.compute (package:analysis_server/src/services/correction/dart/import_add_show.dart:48:10)
#61 AssistProcessor._addFromProducers.compute (package:analysis_server/src/services/correction/assist_internal.dart:207:24)
#62 AssistProcessor._addFromProducers (package:analysis_server/src/services/correction/assist_internal.dart:228:15)
#63 AssistProcessor.compute (package:analysis_server/src/services/correction/assist_internal.dart:181:5)
#64 EditGetAssistsHandler._computeServerAssists (package:analysis_server/src/handler/legacy/edit_get_assists.dart:105:23)
#65 OperationPerformanceImpl.runAsync (package:analyzer/src/util/performance/operation_performance.dart:174:14)
#66 EditGetAssistsHandler.handle (package:analysis_server/src/handler/legacy/edit_get_assists.dart:57:19)
#67 LegacyAnalysisServer.handleRequest.. (package:analysis_server/src/legacy_analysis_server.dart:569:11)
#68 OperationPerformanceImpl.runAsync (package:analyzer/src/util/performance/operation_performance.dart:174:14)
#69 LegacyAnalysisServer.handleRequest. (package:analysis_server/src/legacy_analysis_server.dart:550:7)
Debug log
`
This happens every time I switch a tab in my Android Studio.
I don't know when this started happening, but earlier this used not to happen.
I am stuck to Flutter 3.27.3 though (due to 3.29 disabling Skia backend on iOS), so I am guessing might this be the reason ?
This is my Flutter Doctor output:
`❯ flutter doctor -v
[✓] Flutter (Channel stable, 3.27.3, on macOS 14.6.1 23G93 darwin-arm64, locale en-FI)
• Flutter version 3.27.3 on channel stable at /Users/sakari/dvl/flutter
• Upstream repository https://github.com/flutter/flutter.git
• Framework revision c519ee916e (4 months ago), 2025-01-21 10:32:23 -0800
• Engine revision e672b006cb
• Dart version 3.6.1
• DevTools version 2.40.2
[✓] Android toolchain - develop for Android devices (Android SDK version 35.0.0)
• Android SDK at /Users/sakari/Library/Android/sdk
• Platform android-35, build-tools 35.0.0
• ANDROID_HOME = /Users/sakari/Library/Android/sdk
• Java binary at: /Users/sakari/dvl/jdk/jdk-17.0.13+11/Contents/Home/bin/java
• Java version OpenJDK Runtime Environment Temurin-17.0.13+11 (build 17.0.13+11)
• All Android licenses accepted.
[✓] Xcode - develop for iOS and macOS (Xcode 16.2)
• Xcode at /Applications/Xcode.app/Contents/Developer
• Build 16C5032a
• CocoaPods version 1.16.2
[✓] Chrome - develop for the web
• Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome
[✓] Android Studio (version 2024.3)
• Android Studio at /Users/sakari/Applications/Android Studio.app/Contents
• Flutter plugin can be installed from:
🔨 https://plugins.jetbrains.com/plugin/9212-flutter
• Dart plugin can be installed from:
🔨 https://plugins.jetbrains.com/plugin/6351-dart
• Java version OpenJDK Runtime Environment (build 21.0.6+-13368085-b895.109)
[✓] VS Code (version 1.93.1)
• VS Code at /Applications/Visual Studio Code.app/Contents
• Flutter extension can be installed from:
🔨 https://marketplace.visualstudio.com/items?itemName=Dart-Code.flutter
[✓] Connected device (3 available)
• macOS (desktop) • macos • darwin-arm64 • macOS 14.6.1 23G93 darwin-arm64
• Mac Designed for iPad (desktop) • mac-designed-for-ipad • darwin • macOS 14.6.1 23G93 darwin-arm64
• Chrome (web) • chrome • web-javascript • Google Chrome 136.0.7103.93
! Error: Browsing on the local area network for Moonstone. Ensure the device is unlocked and attached with a cable or associated with
the same local area network as this Mac.
The device must be opted into Developer Mode to connect wirelessly. (code -27)
! Error: Browsing on the local area network for SpacePad. Ensure the device is unlocked and attached with a cable or associated with the
same local area network as this Mac.
The device must be opted into Developer Mode to connect wirelessly. (code -27)
[✓] Network resources
• All expected network resources are available.
• No issues found!`
I am running Android Studio Meerkat Feature Drop | 2024.3.2
Any idea why this is happening ? How might I fix this ?
The text was updated successfully, but these errors were encountered: