issue #24644 add copy constructor with partial value override #24646
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevmoo
added
area-core-library
|
@pcornelissen, can you take a look at the questions from @whesse, please? |
| int minute : null, | ||
| int second : null, | ||
| int millisecond : null, | ||
| bool isUtc:null |
|
Closing this as no response has been received in the above questions. @pcornelissen you are most welcome to re-open it should you have a chance to address the questions. |
|
Well I just wanted to provide some code to help you improve the developer experience, if you don't want it ok. Feel free to use this or do something similar. I don't care ;-) |
|
The idea is good, but instead of making it a constructor, I think it fits
better as a method on the source DateTime. We have a CL for this (
https://codereview.chromium.org/1472803003/), but it's currently blocked on
naming.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have created a small pull request that provides the necessary functionality that I wrote about in my feature request #24644. I have added isUTC copying as well.
I have already submitted the CLA for stuff I did for angularDart.