fix node tests in subdirs (#807)

Author: jakemac53

CHANGELOG.md

@@ -1,3 +1,7 @@
+## 0.12.34+1
+
+* Fixed an issue `--precompiled` node tests in subdirectories.
+
 ## 0.12.34
 
 * Requires at least Dart 1.24.0.

lib/src/runner/node/platform.dart

@@ -194,9 +194,7 @@ class NodePlatform extends PlatformPlugin
       int socketPort,
       String precompiledPath) async {
     StackTraceMapper mapper;
-    var jsPath =
-        p.join(precompiledPath, p.basename(testPath) + ".node_test.dart.js");
-
+    var jsPath = p.join(precompiledPath, '$testPath.node_test.dart.js');
     if (!suiteConfig.jsTrace) {
       var mapPath = jsPath + '.map';
       var resolver = await SyncPackageResolver

pubspec.yaml

@@ -1,5 +1,5 @@
 name: test
-version: 0.12.34
+version: 0.12.34+1
 author: Dart Team <[email protected]>
 description: A library for writing dart unit tests.
 homepage: https://github.com/dart-lang/test

test/runner/precompiled_test.dart

@@ -71,23 +71,25 @@ void main() {
   group("node tests", () {
     test("run a precompiled version of a test rather than recompiling",
         () async {
-      await d.file("test.dart", """
+      await d.dir("test", [
+        d.file("test.dart", """
           import "package:test/src/bootstrap/node.dart";
           import "package:test/test.dart";
 
           void main() {
             internalBootstrapNodeTest(() => () => test("success", () {
               expect(true, isTrue);
             }));
-          }""").create();
+          }""")
+      ]).create();
       await _writePackagesFile();
 
-      var jsPath = p.join(d.sandbox, "test.dart.node_test.dart.js");
+      var jsPath = p.join(d.sandbox, "test", "test.dart.node_test.dart.js");
       var dart2js = await TestProcess.start(
           p.join(sdkDir, "bin", "dart2js"),
           [
             await PackageResolver.current.processArgument,
-            "test.dart",
+            p.join("test", "test.dart"),
             "--out=$jsPath",
           ],
           workingDirectory: d.sandbox);
@@ -97,10 +99,15 @@ void main() {
       await jsFile.writeAsString(
           preamble.getPreamble(minified: true) + await jsFile.readAsString());
 
-      await d.file("test.dart", "invalid dart}").create();
+      await d.dir("test", [d.file("test.dart", "invalid dart}")]).create();
 
-      var test = await runTest(
-          ["-p", "node", "--precompiled", d.sandbox, "test.dart"]);
+      var test = await runTest([
+        "-p",
+        "node",
+        "--precompiled",
+        d.sandbox,
+        p.join("test", "test.dart")
+      ]);
       expect(test.stdout,
           containsInOrder(["+0: success", "+1: All tests passed!"]));
       await test.shouldExit(0);