fix node tests in subdirs #807
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakemac53
added
the
type-bug
natebosch
approved these changes
Apr 10, 2018
lib/src/runner/node/platform.dart
Outdated
| var jsPath = | ||
| p.join(precompiledPath, p.basename(testPath) + ".node_test.dart.js"); | ||
|
|
||
| var jsPath = p.join(precompiledPath, testPath + ".node_test.dart.js"); |
There was a problem hiding this comment.
single quotes for consistency with the line 2 below.
Would also prefer '$testPath.node_test.dart.js'
There was a problem hiding this comment.
done, in general theres a crazy mix of single/double quotes here so eventually we might want to fix that repo-wide, but at least its consistent within this method now...
lib/src/runner/node/platform.dart
Outdated
| @@ -248,7 +246,7 @@ class NodePlatform extends PlatformPlugin | |||
| try { | |||
| return await Process.start(settings.executable, | |||
| settings.arguments.toList()..add(jsPath)..add(socketPort.toString()), | |||
| environment: {'NODE_PATH': nodePath}); | |||
| environment: {'NODE_PATH': nodePath}w); | |||
pulyaevskiy
reviewed
Apr 10, 2018
lib/src/runner/node/platform.dart
Outdated
| @@ -248,7 +246,7 @@ class NodePlatform extends PlatformPlugin | |||
| try { | |||
| return await Process.start(settings.executable, | |||
| settings.arguments.toList()..add(jsPath)..add(socketPort.toString()), | |||
| environment: {'NODE_PATH': nodePath}); | |||
| environment: {'NODE_PATH': nodePath}w); | |||
There was a problem hiding this comment.
Curious what w means in this case?
There was a problem hiding this comment.
it means my finger slipped ;)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was using the basename of the file before, oops!