Skip to content

Prepare for Dart 3 #1811

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
mit-mit opened this issue Dec 8, 2022 · 6 comments · Fixed by #1812
Closed

Prepare for Dart 3 #1811

mit-mit opened this issue Dec 8, 2022 · 6 comments · Fixed by #1812
Assignees
@jakemac53

Comments

@mit-mit
Copy link
Member

mit-mit commented Dec 8, 2022

The source currently contains several references to APIs scheduled for removal in Dart 3 (details here):

Can we move the min up to 3.0, and start working on a dev release version for this?
@jakemac53 jakemac53 self-assigned this Dec 8, 2022
@jakemac53
Copy link
Contributor

jakemac53 commented Dec 8, 2022 •
edited
Loading

We also reference CastError. this was just in matcher actually

@jakemac53
Copy link
Contributor

jakemac53 commented Dec 8, 2022 •
edited
Loading

Another thing to consider here is if we should actually change our lower bound to >3.0.0-0 or not. We could just deprecate the apis, and change them to check against a TypeError instead of CastError/NullThrownError, and remain compatible with 2.x for those users, so we don't leave them behind sooner than we have to.

@jakemac53
Copy link
Contributor

jakemac53 commented Dec 8, 2022 •
edited
Loading

cc @mit-mit what is the timeline here? How soon will this package break in dart 3 (or is it already broken?).

@mit-mit
Copy link
Member Author

mit-mit commented Dec 8, 2022 •
edited
Loading

The plan was to land changes removing the APIs starting Monday, Dec 12th, in Dart main.

The will be breaking in google3, where there's a copy of the package, which would then fail analysis after a google3 roll of the SDK.

@jakemac53
Copy link
Contributor

Ok, so its a P0 then?

@jakemac53 jakemac53 mentioned this issue Dec 8, 2022
Merged
jakemac53 added a commit that referenced this issue Dec 8, 2022
@jakemac53
Prepare for Dart 3.0 api removals (#1812)
c8ac438 
Fixes #1811

I also pre-emptively bumped our dep on matcher, which I think should be fine, but please push back if you disagree.

Moves all null safety related tests into a legacy_tests directory.
@mit-mit
Copy link
Member Author

mit-mit commented Dec 9, 2022

Yes, I believe so

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jakemac53 jakemac53

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Prepare for Dart 3.0 api removals dart-lang/test
2 participants
@jakemac53 @mit-mit