-
Notifications
You must be signed in to change notification settings - Fork 218
Fix node bootstrapping for dart2 #811
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@kevmoo added you for approval to drop Dart 1.x support. Technically, I could remove types instead of adding them and get something that works in both but that just feels wrong and it seems like a good time to make the switch. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Technically, I could remove types instead of adding them and get something that works in both but that just feels wrong and it seems like a good time to make the switch.
SGTM!
Fixes package:test related issues for #766