Skip to content

Fix node bootstrapping for dart2 #811

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Apr 17, 2018
Merged

Fix node bootstrapping for dart2 #811

merged 10 commits into from
Apr 17, 2018

Conversation

jakemac53
Copy link
Contributor

Fixes package:test related issues for #766

@jakemac53 jakemac53 requested a review from kevmoo April 16, 2018 21:35
@jakemac53
Copy link
Contributor Author

@kevmoo added you for approval to drop Dart 1.x support.

Technically, I could remove types instead of adding them and get something that works in both but that just feels wrong and it seems like a good time to make the switch.

Copy link
Member

@kevmoo kevmoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Technically, I could remove types instead of adding them and get something that works in both but that just feels wrong and it seems like a good time to make the switch.

SGTM!

@jakemac53 jakemac53 merged commit c168b03 into master Apr 17, 2018
@jakemac53 jakemac53 deleted the node-fixes branch April 17, 2018 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants