Skip to content

Tests with long timeouts should be moved to a cron job #1846

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
elliette opened this issue Dec 20, 2022 · 2 comments
Closed

Tests with long timeouts should be moved to a cron job #1846

elliette opened this issue Dec 20, 2022 · 2 comments

Comments

@elliette
Copy link
Contributor

We have a few tests with timeouts of 5 minutes, e.g. the devtools_test. This test has recently been flaking, because it times out after 5 minutes, eg: https://github.com/dart-lang/webdev/actions/runs/3743002547/jobs/6354677288

I think it would be best to move these long running tests into a separate cron job, to improve the velocity of Github CI testing.
@elliette elliette mentioned this issue Dec 20, 2022
Open
11 tasks
@elliette
Copy link
Contributor Author

Related: #1847

This was referenced Dec 20, 2022
Merged
Merged
@bkonyi bkonyi closed this as completed Oct 23, 2024
@bkonyi bkonyi reopened this Oct 23, 2024
@bkonyi
Copy link
Collaborator

bkonyi commented Oct 23, 2024

@elliette has made other improvements to reduce the amount of time needed to run testing (e.g., sharding), so this isn't as relevant anymore.

@bkonyi bkonyi closed this as completed Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@elliette @bkonyi