You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Make it clearer what parameters should be passed to TestContext (eg, it is unclear the difference between path vs pathToServe). Also the default Dart entry file is in append_body, but the default HTML entry file is in hello_world.
Currently a lot of the fields in TestContext are late, because they are only initialized after TestContext.setUp() is called. I think it would make more sense to have two separate classes for test setup: TestPackage which is equivalent to TestContext , and TestContext which is equivalent to TestContext.setUp().
dwds/test/fixtures directory contains dill files (used for testing) along with utilities.dart (test utilities) and context.dart (test setup). This should be reorganized.
The text was updated successfully, but these errors were encountered:
CI improvements (reduce time it takes for Github actions to run):
devtools _test
at 5 minutes) to a cron job (tracked in Tests with long timeouts should be moved to a cron job #1846)Refactor
TestContext
setup:TestServer
more re-usable (described in Make DWDS test server more re-usable #1779)TestContext
(eg, it is unclear the difference betweenpath
vspathToServe
). Also the default Dart entry file is inappend_body
, but the default HTML entry file is inhello_world
.TestContext
constructor for clarity #1844 and Tests should servemain.dart
andindex.html
from the same directory #1856TestContext
arelate
, because they are only initialized afterTestContext.setUp()
is called. I think it would make more sense to have two separate classes for test setup:TestPackage
which is equivalent toTestContext
, andTestContext
which is equivalent toTestContext.setUp()
.Other improvements:
fixtures
are formatted (described in Call stack tests break ifmain.dart
infixtures/_testPackageSound
/fixtures/_testPackage
is formatted #1831)mono_pkg.yml
file, so that theanalyze
andformat
steps can be run against them during CIpuppeteer
for all integration tests (tracked in Switch to usingpuppeteer
instead ofWebDriver
for all integration tests #1847)dwds/test/fixtures
directory contains dill files (used for testing) along withutilities.dart
(test utilities) andcontext.dart
(test setup). This should be reorganized.The text was updated successfully, but these errors were encountered: