Skip to content

Add running tests on min SDK and current beta #1392

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 31, 2021

Conversation

annagrin
Copy link
Contributor

@annagrin annagrin commented Aug 24, 2021

  • Run webdev and dwds tests on stable and beta
    • prevent breaks on latest stable
    • prevent breaks on next SDK stable release

Related: #1390
Closes: #1393

- Run webdev tests on 2.13.4 and beta
  - prevent breaks on latest stable
  - prevent breaks on next SDK stable release
- Run dwds tests on beta
  - prevents breaks on next SDK stable release
Copy link
Member

@devoncarew devoncarew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment -

(is .github/workflows/dart.yml generated? I see a lot of diffs there, and it doesn't look hand-authored)

@annagrin
Copy link
Contributor Author

(is .github/workflows/dart.yml generated? I see a lot of diffs there, and it doesn't look hand-authored)

Yes, it is generated by pub global run mono_repo generate command.

Anna Gringauze added 2 commits August 25, 2021 10:44
- Run tests in CI for stable and dev
- Move tests on beta to a sheduled job instead of on PR
- Add tests to ensure that min SDK constraint in webdev and dwds
  matches major and minor versions of the current stable.
@annagrin
Copy link
Contributor Author

Re-requesting review for the latest update - changing min SDK constraint in dwds and webdev to match the current stable's major and minor versions.

@annagrin annagrin merged commit b197872 into dart-lang:master Aug 31, 2021
@annagrin annagrin deleted the annagrin/add_test_on_stable branch August 31, 2021 23:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add running tests on min SDK and current beta
4 participants