Skip to content

Migrate some dwds files to null safety #1635

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Jun 13, 2022
Merged

Migrate some dwds files to null safety #1635

merged 12 commits into from
Jun 13, 2022

Conversation

annagrin
Copy link
Contributor

@annagrin annagrin commented Jun 3, 2022 •
edited
Loading

  • Migrate some dwds files (the ones that don't have dwds dependencies) to null safety.
  • Expose ExpressionCompiler and AssetReader interfaces so they can be imported separately from dwds.dart
    • needed to break cyclic dependency with package:frontend_server_common that would be migrated to null safety next.

Towards: #1327

@annagrin annagrin requested review from nshahan, elliette and grouma June 3, 2022 00:52
nshahan
nshahan reviewed Jun 3, 2022
View reviewed changes
grouma
grouma reviewed Jun 6, 2022
View reviewed changes
annagrin
annagrin commented Jun 8, 2022
View reviewed changes
Copy link
Contributor Author

@annagrin annagrin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank everyone for very useful comments! Addressed them.

@annagrin annagrin requested review from grouma, elliette and nshahan June 8, 2022 23:54
elliette
elliette reviewed Jun 9, 2022
View reviewed changes
nshahan
nshahan approved these changes Jun 9, 2022
View reviewed changes
Copy link
Contributor

@nshahan nshahan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with the pending comments.

elliette
elliette approved these changes Jun 10, 2022
View reviewed changes
Copy link
Contributor

@elliette elliette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once pending comments are addressed

@annagrin annagrin merged commit 36561ff into dart-lang:master Jun 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grouma grouma grouma approved these changes

@nshahan nshahan nshahan approved these changes

@elliette elliette elliette approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@annagrin @grouma @nshahan @elliette